Icon Sometimes Wrong #66


Open
  • xodiv created this issue Apr 8, 2019

    LoggerHead has a few problems with the icon sometimes displaying incorrectly, which all stem from a single cause: LoggingCombat() does not just return true or false, but also sometimes nil to indicate the state is not known yet.

     

    LoggerHead always treats this as false (logging not enabled) but LoggingCombat() returns nil both when it is transitioning from on to off, and from off to on. In my testing with advanced combat logging enabled, it returned the unknown state for up to 12 seconds after being changed.

     

    You can trivially trigger this behavior by clicking the icon twice quickly.

     

    I guess it's worth noting that the Blizzard /combatlog slash command suffers from the same problem (in the message it prints to chat).


To post a comment, please login or register a new account.