r145: Classic Forever goes through retail code paths, so sub-menu checkbox clicks are lost and menus no longer auto-hide #23


Open
  • gogo1951 created this issue Oct 13, 2026

    Hi! First off, thanks for maintaining LibUIDropDownMenu. A lot of us depend on it.

     

    We recently moved from an older revision (r117-based) to r145 and found a regression on the Classic “Forever” client (mainline engine, interface 16001).

     

    What happens

    1. Sub-menu checkbox clicks don’t stick. Ticking a checkbox entry in a nested sub-menu shows the checkmark, but the entry’s func never updates the backing setting, so the choice is gone once the menu closes. Top-level checkbox entries still work.
    2. Menus no longer auto-hide. Before, menus closed about 2 seconds after the mouse left them. On r145 they stay open on Forever.

    When you select a sub-option in the menu, it doesn't save.

     

    Move your mouse off, and back again and this happens.

     

    Likely cause

    r145 detects Forever as isClassicForever and sends it through the retail code paths. Older revisions compared only the interface version, so Forever was treated as Classic Era and used the classic paths. Both the sub-menu click handling and the auto-hide timer worked there.

     

    We traced the click problem to the retail paths running on Forever but haven’t found the exact step where the click gets dropped.

     

    Workaround we’re using locally

     

    Keep Forever on the classic paths:

     
    lua
    isClassicForever = false
    -- and include isForeverBeta in isAnyClassic

    With that change, sub-menu toggles save correctly and the auto-hide timer works again. The change only affects clients where isForeverBeta is true.

     

    Steps to reproduce

    1. On a Forever client, open a dropdown menu with a nested sub-menu that has checkbox entries (keepShownOnClick, func that writes a saved variable).
    2. Tick an entry in the sub-menu.
    3. Close the menu and reopen it. The entry is unticked and the setting wasn’t written.
    4. Also: move the mouse off any open menu and wait. It doesn’t close.

    Happy to test a fix or share more details. Thanks again!

  • gogo1951 posted a comment Oct 13, 2026

    Think this is fixed in 147? Guess I better try that too. (=

  • gogo1951 posted a comment Oct 13, 2026

    Confirmed, still an issue in latest build. Thanks!

  • gogo1951 edited description Oct 13, 2026
  • gogo1951 edited description Oct 13, 2026

To post a comment, please login or register a new account.