Border - None 5.0.4 issue. #5


  • Fixed
  • Patch
Closed
Assigned to elkano
  • Suicidal_Katt created this issue Aug 27, 2012

    What steps will reproduce the problem?
    1. Open a 5.0.4 Enabled Client
    2. Assign a border appropriate SharedMedia addon's texture to "None"
    3. Look at a green mess.

    What is the expected output? What do you see instead?
    A simple non-bordered frame.

    What version of the product are you using?
    LibSharedMedia-3.0-6.zip

    Do you have an error log of what happened?
    No.

    Please provide any additional information below.
    New Blizzard handling of textures will use a green texure if a texture is undefined or missing.
    Simply changing what the 'None' texture path is in the LibSharedMedia-3.0.lua file on line 77 to:
    lib.MediaTable.border["None"]                                = [[Interface\AddOns\SharedMedia\border\none]]

    ...and include this texture file under border within the addon folder:
    https://dl.dropbox.com/u/4479083/none.tga

  • Suicidal_Katt added the tags New Patch Aug 27, 2012
  • Suicidal_Katt added an attachment WoWScrnShot_082712_165542.jpg Aug 27, 2012

    WoWScrnShot_082712_165542.jpg

    <p>Before Fix</p>

  • Suicidal_Katt added an attachment WoWScrnShot_082712_165605.jpg Aug 27, 2012

    WoWScrnShot_082712_165605.jpg

    <p>After Fix</p>

  • Suicidal_Katt edited description Aug 27, 2012
  • Elkano posted a comment Aug 28, 2012

    Current behavior (returning nil for none) is working fine in MoP beta with other addons, e.g. Chatter.

  • Forge_User_29634589 posted a comment Aug 30, 2012

    i had the same issue thanks for the fix suicidalkatt

  • _ForgeUser4083700 posted a comment Sep 2, 2012

    1x libs\LibStatLogic-1.2\LibStatLogic-1.2-114.lua:478 attempt to call local "strutf8lower" (a nil value)
    libs\LibStatLogic-1.2\LibStatLogic-1.2-114.lua:478 in main chunk

    Locals:


    Edited Sep 3, 2012
  • Suicidal_Katt posted a comment Sep 2, 2012

    @Elkano: Go

    Why not fix the issue within SharedMedia rather than have addons change their methods?

  • Phanx posted a comment Sep 6, 2012

    @suicidalkatt:

    Could you post some code demonstrating a problem? Setting the border texture to "None" in Grid works as expected; the border is hidden, and I don't see any green blocks. I even installed Stuf (based on your screenshot) and couldn't reproduce the problem there either.


    Edited Sep 6, 2012
  • MrFIXlT posted a comment Sep 7, 2012

    Came to post the same thing but it turns out it's problem on addon side.

    This happens if you try to pass a 'non-existing texture' path to SetBackdrop instead of nil.

  • Suicidal_Katt posted a comment Sep 7, 2012

    <<reply 933967>>

    Stuf recently addressed the issue, but any other addon that uses SetBackdrop like Dridzt mentioned without allowing the texture to be nil or false will return a green texture since 'lib.MediaTable.border["None"]' isn't defined to a texture path within SharedMedia.

    Regardless now SharedMedia's lib.MediaTable.border["None"] is now set to [[]] (used to be [[Interface\None]])to correct the issue.

    Made a simple addon to test for the issue: https://dl.dropbox.com/u/4479083/NoneBorder.zip


    Edited Sep 8, 2012
  • Elkano removed a tag New Sep 9, 2012
  • Elkano added a tag Fixed Sep 9, 2012
  • Elkano closed issue Sep 9, 2012

To post a comment, please login or register a new account.