Problem with IsDesaturated() if it returns secrets #31


Open
  • millanzarreta created this issue Feb 1, 2026

    In the library (current alpha 0.57-14-g004f030-alpha version), the UpdateUsable function calls :IsDesaturated(). However, if desaturation is set using secrets (by another addon, for example), IsDesaturated() returns a secret, which causes errors at that point.

     

    Given what it does, I think this check could probably be removed entirely.

     

     

  • millanzarreta edited description Feb 1, 2026
  • WilduTools posted a comment Feb 13, 2026

    one fix would be `if issecretvalue(self.icon:IsDesaturated()) then return end`

  • user_2hhcr1s8e1v0zfhi posted a comment Mar 20, 2026

    Figured I'd add my experience here. using GreyOnCooldown and bartender4 the low resource indication and some proc effects on brewmaster were not working. I deleted the saturation check as you mentioned in the issue you made for libactionbutton and it fixed my issue https://legacy.curseforge.com/wow/addons/libactionbutton-1-0/issues/31

    @wilduTools it appears that `if issecretvalue(self.icon:IsDesaturated()) then return end` does not fully resolve the issue

  • millanzarreta posted a comment Mar 23, 2026

    That part of the code could actually be written like this, and it would be equivalent while avoiding any conflicts with secrets:

     

    	...
    	if WoWRetail and self._state_type == "action" then
    		local isLevelLinkLocked = C_LevelLink.IsActionLocked(self._state_action)
    		if isLevelLinkLocked then
    			self.icon:SetDesaturated(true)
    		end
    
    		if self.LevelLinkLockIcon then
    			self.LevelLinkLockIcon:SetShown(isLevelLinkLocked)
    		end
    	end
    	...

     

  • houseofficer1 posted a comment Mar 23, 2026

    i dont actually have libaction button installed, howcome greyoncooldown still needs it fixed? do i need to install libactionbutton and change code? Im happy to do that to get this working, such a vital addon for my UI


To post a comment, please login or register a new account.