core.lua:654 - #20


Open
  • amey0 created this issue Jul 24, 2018

    same as issue reported last may - by me

     

    HitsMode5\Core.lua:654: attempt to concatenate local 'a' (a nil value)
    HitsMode5\Core.lua:654: in function `?'
    ...que\Libs\CallbackHandler-1.0\CallbackHandler-1.0-7.lua:145: in function <...que\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:145>
    [string "safecall Dispatcher[18]"]:4: in function <[string "safecall Dispatcher[18]"]:4>
    [C]: ?
    [string "safecall Dispatcher[18]"]:13: in function `?'
    ...que\Libs\CallbackHandler-1.0\CallbackHandler-1.0-7.lua:90: in function `Fire'
    ...aceTomTom\libs\AceEvent-3.0\AceEvent-3.0-4.lua:120: in function <...aceTomTom\libs\AceEvent-3.0\AceEvent-3.0.lua:119>

  • Fizzlemizz posted a comment Jul 24, 2018

    It appears the event text is occaisionaly returning something with a new format (I haven't tracked it down yet)

     

    For the time being, after the line:

    if b and f.db.display.includeRestedExperience then a = (a or "").." (+"..b..L[" rested"]..")" end

    add

     

    if not a then a = "" end

    I will try and get a better fix when I get the error again if Allara doesn't get in first..


    Edited Jul 24, 2018
  • amey0 posted a comment Jul 25, 2018

    again, appreciate the help. i can copy/paste or comment out with the best of them, but anything more than that is way above my pay scale. ;)

     

  • Fizzlemizz posted a comment Jul 26, 2018

    I have not seen the error again so I'm guessing that Blizzard fixed the format of the event parameter that caused the problem. Fingers crossed this is all.

  • Fizzlemizz posted a comment Aug 2, 2018

    It appears followers are getting XP in BfA and the error posted was due to that. An example of the new message:

    [Stormcaller Mylra] has earned 30 xp.

    I create a new entry in the enUS.lua localisation file

    L["CHAT_MSG_COMBAT_XP_GAIN_3"] = ".* earned (%d+).*" -- Followers "Earn" xp

    Then in core.lua below line 650

    _, _, a = string.find(arg1, L["CHAT_MSG_COMBAT_XP_GAIN_1"]) -- .* gain (%d+).*

    I added:

    if not a then
             _, _, a = string.find(arg1, L["CHAT_MSG_COMBAT_XP_GAIN_3"]) -- .* earned (%d+).* -- For followers
    end

     

     


To post a comment, please login or register a new account.