Indicator for Soothing Mist (Statue) disappearing #877


  • Defect
Open
  • guardog88 created this issue Oct 6, 2020

    What version of Grid2 and game type (classic or retail) are you using?
    Retail Grid2 r981

     

    What game client version (windows or mac) and language are you using?
    Windows EN-US

     

    What steps will reproduce the problem?
    1) Create a buff that tracks the statue version of Soothing Mist (mine only) - id 198533
    2) Load the buff into a square indicator
    3) With the statue targeted, cast soothing mist on self, then cancel the self casted version so that the statue will continue casting - there will be no indicator
    4) Untarget statue, after sometime the indicator will appear again, selecting the statue will again hide the indicator

     

    The same behaviour can be observed by mouseover/setting the statue as focus - focusing it will hide the indicator, unfocus it and the indicator will show.

     

    This can be explained by the peculiar nature of the aura shown in the UI depending on whether the statue is targeted/focused - when it is not focused/targeted, the source of the aura is the player, but when the statue is targeted/focused, the source (from UnitAura) changed to target/focus. (I can only confirm target/focus and not mouseover, but the changing in positioning of the soothing mist aura when I mouseover the statue should be caused by the same reason)

    Did you try having Grid2 as the only enabled addon and everything else disabled?
    Yes, the same behaviour is observed

     

    Was it working in a previous version? If yes, which was the last good one?
    Unsure

     

    Do you have an error log of what happened? If you don't see any errors, make sure that error reporting is enabled (`/console scriptErrors 1`) or install [BugSack](https://mods.curse.com/addons/wow/BugSack).
    No error is produced by the bug

     

    Please provide any additional information below.
    I was concerned with the random disappearance of the indicator during combat (probably due to mouseovers), which led to this discovery.

     

    EDIT: Seems like it is a limitation caused by the UnitAura API, not sure if there is any way around it.

  • guardog88 added a tag Defect Oct 6, 2020
  • guardog88 edited description Oct 6, 2020
  • guardog88 edited description Oct 6, 2020
  • guardog88 posted a comment Oct 7, 2020

    I have created this WeakAura (https://wago.io/Uxl8FuaFI) to overcome this limitation, as a temporary (?) solution .

  • michaelsp posted a comment Oct 7, 2020

    I have to decline, im not going to add expensive operations like combatlog tracking to the auras management code, even the workaround is not perfect, Its not possible to track the distance to the statue (<40 yards) to remove the aura.

    On the other hand an  acceptable option could be to code an independent status to track this special case.


    Edited Oct 7, 2020
  • guardog88 posted a comment Oct 7, 2020

    I can understand your decision on the CLEU scanning part, it was used in the workaround to guess/calculate the duration information - which is another problem altogether. Like you said, it can still be unreliable due to CLEU's limitation.

     

    If we are to focus on the disappearance of indicator (when tracking own statue's soothing mist) - the cause is actually the source unit information from UnitAura changing from "player" to "target", "focus" and "mouseover". The same behaviour can be observed on shaman totems, so I guess it is a problem worth working on?

     

    Here's a suggestion:

    1. Whenever UnitAura returns a source unit that can be both self or non-self ("target", "focus", etc.) get its UnitGUID and then use the snippet below to determine whether the owner is the player.

     

    https://www.wowinterface.com/forums/showpost.php?p=297190&amp;postcount=2

     

    If the owner is the player, change the source unit to "player" (?)

     

    2. Cache the GUID information so that next query with the same GUID doesn't need to involve the snippet above.

  • michaelsp posted a comment Oct 9, 2020

    The addon always retrieve the player auras calling UnitAura('player') or if the player is in raid the corresponding unit for the player ('raid1','raid2', etc), so the actual focus or target is irrelevant. And I cannot assume an aura exists on the player if UnitAura('player') says the aura does not exist.


    Edited Oct 9, 2020
  • guardog88 posted a comment Oct 9, 2020

    The problem is not UnitAura saying an aura does not exist, in this case it exists - only that the source unit is changed to "focus", "target" or "mouseover" (and not "player" even though soothing mist is from the same statue). Hence the indicator showing a "player" aura will occasionally disappear due to the source unit changing, and not UnitAura saying the aura does not exist.

  • michaelsp posted a comment Oct 9, 2020

    I don't understand what you mean. The addon always uses the "player" unit (not focus,target or mouseover) to query for the auras, are you telling me that "player" unit does not represent the player for some time ?

    If this is  the case the shooting mist missing is the least of the problems, because all displayed data will be wrong for the player, all buffs/debuffs and even the amount of health displayed.

     


    Edited Oct 9, 2020
  • guardog88 posted a comment Oct 9, 2020

    The source unit value that returns from UnitAura changes from "player" to "target" when you target the statue while it is channeling and the aura no longer is shown as from the player. Same for mouseover and focus.

     

    The addon is working as intended to treat aura from "player" as from the player, but the problem arises when you target the statue, the source changes to "target" and it no longer shows on the addon - despite being the same aura from the player.


    Edited Oct 9, 2020
  • michaelsp posted a comment Oct 9, 2020

    Ok, i got it,  the issue arises only for show-if-mine buffs.


    Edited Oct 9, 2020
  • guardog88 posted a comment Oct 10, 2020

    yea, more specifically show-if-mine buff from totems - the same behaviour can be observed for shamans.


    Edited Oct 10, 2020

To post a comment, please login or register a new account.