Shadowlands Beta: Errors due to API Changes #856


  • Fixed
Closed
  • kadecgos created this issue Jul 18, 2020

    What version of Grid2 are you using?

    r955

     

    What game client version (windows or mac) and language are you using ?

    9.0.1.35213 - Windows

     

    What steps will reproduce the problem?

    1.  Install and Enable Grid2

    2.  Log into the game.

    3.  ---> A couple of errors appear upon login 


    Did you try having Grid2 as the only enabled addon and everything else disabled?

    I did!

      

    Was it working in a previous version? If yes, which was the last good one?

    No previous version.

      

    Do you have an error log of what happened? If you don't see any errors, make sure that error reporting is enabled (`/console scriptErrors 1`) or install [BugSack](https://mods.curse.com/addons/wow/BugSack).

     

    2 Errors appear on startup:

     

    ---

     

    Message: Interface\AddOns\Grid2\modules\StatusHealth.lua:69: Attempt to register unknown event "UNIT_HEALTH_FREQUENT"
    Time: Sat Jul 18 00:51:55 2020
    Count: 1
    Stack: Interface\AddOns\Grid2\modules\StatusHealth.lua:69: Attempt to register unknown event "UNIT_HEALTH_FREQUENT"
    [string "=[C]"]: in function `RegisterEvent'
    [string "@Interface\AddOns\Grid2\modules\StatusHealth.lua"]:69: in function <Interface\AddOns\Grid2\modules\StatusHealth.lua:64>
    [string "@Interface\AddOns\Grid2\modules\StatusHealth.lua"]:152: in function <Interface\AddOns\Grid2\modules\StatusHealth.lua:149>
    [string "@Interface\AddOns\Grid2\modules\StatusHealth.lua"]:170: in function `OnEnable'
    [string "@Interface\AddOns\Grid2\GridStatus.lua"]:92: in function `RegisterIndicator'
    [string "@Interface\AddOns\Grid2\GridIndicator.lua"]:46: in function `RegisterStatus'
    [string "@Interface\AddOns\Grid2\GridSetup.lua"]:64: in function `SetupStatusMap'
    [string "@Interface\AddOns\Grid2\GridSetup.lua"]:79: in function `Setup'
    [string "@Interface\AddOns\Grid2\GridCore.lua"]:159: in function `LoadConfig'
    [string "@Interface\AddOns\Grid2\GridCore.lua"]:147: in function <Interface\AddOns\Grid2\GridCore.lua:131>
    [string "=[C]"]: ?
    [string "@Interface\AddOns\Grid2\Libs\AceAddon-3.0\AceAddon-3.0.lua"]:70: in function <...face\AddOns\Grid2\Libs\AceAddon-3.0\AceAddon-3.0.lua:65>
    [string "@Interface\AddOns\Grid2\Libs\AceAddon-3.0\AceAddon-3.0.lua"]:527: in function `EnableAddon'
    [string "@Interface\AddOns\Grid2\Libs\AceAddon-3.0\AceAddon-3.0.lua"]:620: in function <...face\AddOns\Grid2\Libs\AceAddon-3.0\AceAddon-3.0.lua:605>
    [string "=[C]"]: in function `LoadAddOn'
    [string "@Interface\FrameXML\UIParent.lua"]:493: in function `UIParentLoadAddOn'
    [string "@Interface\FrameXML\UIParent.lua"]:616: in function `TimeManager_LoadUI'
    [string "@Interface\FrameXML\UIParent.lua"]:1353: in function <Interface\FrameXML\UIParent.lua:1250>

    Locals: <none>

     

    ---

     

    Message: Interface\AddOns\Grid2\GridUtils.lua:204: attempt to call method 'SetBackdrop' (a nil value)
    Time: Sat Jul 18 00:51:55 2020
    Count: 1
    Stack: Interface\AddOns\Grid2\GridUtils.lua:204: attempt to call method 'SetBackdrop' (a nil value)
    [string "@Interface\AddOns\Grid2\GridUtils.lua"]:204: in function `SetFrameBackdrop'
    [string "@Interface\AddOns\Grid2\GridLayout.lua"]:622: in function `UpdateTextures'
    [string "@Interface\AddOns\Grid2\GridLayout.lua"]:197: in function `OnModuleEnable'
    [string "@Interface\AddOns\Grid2\GridCore.lua"]:72: in function <Interface\AddOns\Grid2\GridCore.lua:71>
    [string "=[C]"]: ?
    [string "@Interface\AddOns\Grid2\Libs\AceAddon-3.0\AceAddon-3.0.lua"]:70: in function <...face\AddOns\Grid2\Libs\AceAddon-3.0\AceAddon-3.0.lua:65>
    [string "@Interface\AddOns\Grid2\Libs\AceAddon-3.0\AceAddon-3.0.lua"]:527: in function `EnableAddon'
    [string "@Interface\AddOns\Grid2\Libs\AceAddon-3.0\AceAddon-3.0.lua"]:540: in function `EnableAddon'
    [string "@Interface\AddOns\Grid2\Libs\AceAddon-3.0\AceAddon-3.0.lua"]:620: in function <...face\AddOns\Grid2\Libs\AceAddon-3.0\AceAddon-3.0.lua:605>
    [string "=[C]"]: in function `LoadAddOn'
    [string "@Interface\FrameXML\UIParent.lua"]:493: in function `UIParentLoadAddOn'
    [string "@Interface\FrameXML\UIParent.lua"]:616: in function `TimeManager_LoadUI'
    [string "@Interface\FrameXML\UIParent.lua"]:1353: in function <Interface\FrameXML\UIParent.lua:1250>

    Locals: <none>

     

  • michaelsp posted a comment Jul 18, 2020

    I have no access to the beta, so this kind of issues must wait for an open beta or release.

  • DevSkamer posted a comment Jul 23, 2020

    Hello michaelsp,

    I'm preparing with my guild for raid tests, so i need Grid 2 is working for a better experience. As i'm also an addon author, i was enable to fix it from my own.

    Here below, the changes are needed for Shadowlands:

     

     

    -1. UNIT_HEALTH_FREQUENT event has been removed, as notified here: https://www.townlong-yak.com/framexml/34003/Blizzard_APIDocumentation/UnitDocumentation.lua/diff#987

     

    -2. SetBackdrop no longer exists by default for Frame. There was an alert about that by Wowhead: https://www.wowhead.com/news=316954/addons-now-available-for-use-in-shadowlands-beta 

    So now, if you want to retrieve SetBackdrop for Frame, you need inherit from "BackdropTemplate":

    CreateFrame("Frame", name, parent, "BackdropTemplate")

     

    After these two issues fixed, the addon works fine, i was be able to import my profile of retail.

    I'll look how the addon will behave during the raid tests.

     

  • michaelsp posted a comment Jul 23, 2020

    UNIT_HEALTH case is easy to fix but SetBackdrop change is more problematic, as far as i know there are some undocumented differences between old and the new BackdropTemplate table definition, but unfortunatelly i cannot perform any regression and performace tests with the new Template.


    Edited Jul 23, 2020
  • michaelsp posted a comment Aug 13, 2020

    Grid2 r973-beta must work in Shadowlands.

  • michaelsp added a tag Started Aug 13, 2020
  • michaelsp closed issue Aug 14, 2020
  • michaelsp added a tag Fixed Aug 14, 2020
  • michaelsp removed a tag Started Aug 14, 2020

To post a comment, please login or register a new account.