Classic: Overheal and heal prediction statuses don't change values when HP is reduced #756


  • Accepted
Open
  • BujuArena created this issue Oct 21, 2019

    What version of Grid2 are you using?

     

    936-classic

     

    What game client version (windows or mac) and language are you using ?

     

    WoW Classic (latest); English; Windows 7 64-bit

     

    What steps will reproduce the problem?

     

    1. Add a healing prediction status attached to the end of the current HP bar and an overhealing prediction status to another bar in Grid2.

    2. Start a heal on yourself while in combat with an enemy who deals damage to you.  This heal must be predicted to heal for more than your missing HP.

    3. Take an amount of damage while the heal is being cast that is less than the overhealing prediction.

     

    At this point, the overheal and heal prediction statuses will stay the same instead of being updated. The heal prediction will no longer fill the missing HP area, even though the overheal bar will still have a value above 0.  The expected behavior is for the heal prediction status to continue to fill the missing HP, and the overheal prediction status to shrink by the amount of damage taken.

      
    Did you try having Grid2 as the only enabled addon and everything else disabled?

     

    No, but I'm pretty sure no other addons are interfering with this test.

      

    Was it working in a previous version? If yes, which was the last good one?

     

    I'm not sure if this was ever working as expected in Classic.

      

    Do you have an error log of what happened? If you don't see any errors, make sure that error reporting is enabled (`/console scriptErrors 1`) or install [BugSack](https://mods.curse.com/addons/wow/BugSack).

     

    No, this is not related to Lua errors.

      

    Please provide any additional information below.

     

    There's no more info to provide.

  • Egregious posted a comment Oct 24, 2019

    I am having a similar issue where the predictive healing has ceased functioning.

    I had the feature configured so that Indicator under "text-down" would color green and read the number of the incoming heal as well as the Indicator under "heals" display heals-incoming (bar fill with incoming healing).

     

    Additionally, the Death feature doesn't update the text to "Dead" if a player has died. It simply displays whatever other options have been selected.

    This is a video of Grid2 working with healing prediction: https://www.twitch.tv/videos/495202104
    This is the most recent Grid2 not working: https://www.twitch.tv/videos/498267631


    Edited Oct 24, 2019
  • BujuArena posted a comment Oct 24, 2019

    That's not a similar issue.  That's unrelated.  Please open a separate issue report.

  • jeftep posted a comment Oct 24, 2019

    Heal prediction also stopped working for me. Not cool.

  • BujuArena posted a comment Oct 24, 2019

    That's not what this report is about.  Please open a separate issue report instead of commenting in an unrelated report.

  • michaelsp added a tag Accepted Oct 24, 2019
  • michaelsp posted a comment Oct 24, 2019

    As BujuArena said, please fill a proper ticket with relevant information (like grid2 version, etc) about the heal_prediction issue. But before this, please check your incoming-heals setup: new Grid2 classic version has the posibility to exclude the player heals, displaying only other players heals, and now it is the default option, so go to:

    Statuses->health&heals->heals-incoming

    And activate the  "Include Player Heals" option.

  • michaelsp posted a comment Oct 27, 2019
     r938-beta-classic must fix the overheals issue.
    The heals issue is more tricky, im not sure of fixing this, anyways in ten years no body cared about this issue, only you now ;)

    Edited Oct 27, 2019
  • BujuArena posted a comment Oct 29, 2019

    Thanks for fixing the overheal prediction part of this!  That being said, both halves of this go together, as it doesn't make sense to show an overhealing prediction if the healing status doesn't reach the top of the health bar.  The addition of this overhealing prediction is the only thing that alerted me to this issue in the first place.  I think before, nobody noticed because they just thought the healing prediction was a bit wrong after taking a hit, which it was.

  • Beaving posted a comment Oct 29, 2019

    Since the brand new update, when I place a HoT on a player (or myself), it will only predict the next heal tick, but not take into account all the ticks that the HoT will heal like it did before.

  • michaelsp posted a comment Oct 29, 2019

    The new Grid2 version now uses a different healcomm library, that present some differences, the previous library cannot be used anymore.


    Edited Oct 29, 2019
  • pie4all88 posted a comment Jan 12, 2020

    While it appears the overhealing aspect of this ticket has been fixed, there is still an issue when the target of an incoming heal that would heal them to full takes damage before the heal completes.  I am speaking about the Classic WoW version of the addon.

     

    heals-incoming seems to cap at the player's max health and does not update if the target takes damage while you are in the process of casting. For example, if the target has 800 out of 1000 health and you cast a 300-HP heal on them, but they take 100 damage while you are in the process of casting, the display will only show an incoming heal of 200, to 900 out of 1000 HP even though the spell will heal them to full.

     

    In my opinion, "heals-incoming" should either get updated when damage is taken (like what is successfully happening to "overhealing"), or bars anchored to other indicators (like "health") should be allowed to extend past the boundaries of the frame.

     

    What version of Grid2 are you using?

    r943-classic

     

    What game client version (windows or mac) and language are you using? 

    WoW Classic (latest); English; Windows 7 64-bit

     

    What steps will reproduce the problem?

     

    1. Add a "heals-incoming" status attached to the end of the current HP bar.

    2. Start a heal on yourself while in combat with an enemy who deals damage to you.  This heal must be predicted to heal for more than your missing HP.

    3. Take an amount of damage while the heal is being cast that is less than the overhealing prediction.

     

    At this point, the predicted incoming heal will stay the same instead of being updated to fill the remainder of your health bar. The heal prediction will no longer fill the full missing HP area like it should.

      


To post a comment, please login or register a new account.