Tooltips in combat #631


  • Fixed
  • Enhancement
Closed
  • Kezo_ created this issue Jan 10, 2019

    Ever since you introduced the tooltip indicator, tooltips no longer showed up in combat for me. Even when I went to Indicators -> tooltip -> Layout -> Show status in Tooltip -> Always, still no tooltip would show up in combat. I recently found out that this option only works if you actually SELECT a status - so I went with the "name" status for testing purposes. With this selected, tooltips now show up in combat again, even though I don't think anything is added to the tooltip at all (I assume the status is supposed to add status text to the tooltip, so in this case it should add the player name to the tooltip?). The thing is, I don't actually want Grid2 to mess with the tooltip at all, so it's really strange to me that I actually HAVE to add a status to the tooltip to be able to show a tooltip in combat. When you change the "Show status in Tooltip" setting in the Layout tab, this should only affect the display setting of the actual STATUS and not of the entire tooltip. Maybe you could instead add another option to control visibility of the tooltip in and out of combat?

  • michaelsp posted a comment Jan 10, 2019

    Now Tooltip is an indicator, and the reason to convert the tooltip into an indicator is to be able to display different kind of information (not only the unit name tooltip information) so tooltip indicator follows the logic of the rest of indicators:

     

    An indicator is only a display container (a text, a square, an icon, etc), you must link a status to the indicator to select which kind of information must be displayed in the indicator: for example i link debuffs statuses to this indicator, because i want to see detailed debuffs information in combat, and if you want to display the unit name/information you must link the "name" status to the indicator,

     

    The only special case is the option "Always show unit tooltips out of combat" that works without linking any status to the indicator,  option that really i don't like because goes against the logic of the indicators/status system.

     

    In Conclusion: working as intended. But any suggestion about changes to make more coherent the tooltip implementation (without breaking the indicators/statuses logic and without losing functionality) is welcome.


    Edited Jan 10, 2019
  • michaelsp added a tag Declined Jan 10, 2019
  • Kezo_ posted a comment Jan 10, 2019

    I know how indicators and statuses work, I've been using Grid/Grid2 for many years now. The issue I have is that unit tooltips now only show up if I link a status, even though I don't want to actually use this indicator, I only want my default unit tooltips to show up all the time, whether I am in combat or not, which has always been default behaviour before the tooltip indicator was introduced. This not only means I am forced to link a status to my tooltip if I want it to show up in combat, it is also very unintuitive to figure out if you just want to display your default tooltip. I'd assume many users will be confused as to why their tooltips don't show up in combat anymore after updating Grid2, including me - as there is no option in Grid2 to explicitly "hide tooltips in combat", only an option to not show the tooltip indicator in combat, my first thought was that maybe some other addon I use was messing around with my tooltip.

     

    I currently implemented a workaround for me by editing line 25 of IndicatorTooltip.lua, changing it from "if tooltipOOC and not InCombatLockdown() then" to "if true then" so Grid2 will always display my tooltip as if I was out of combat. 

     

    I assume by "goes against the logic of the indicators/status system" you mean displaying an indicator when no status is linked, but if you're only showing the default tooltip when no status is linked, wouldn't that mean that the indicator is not displayed at all, so it should not break the logic? Maybe the tooltip indicator needs to be considered a special case: other indicators do not need to display any data if no status is linked, as they do not replace any element of the default user interface. But if the tooltip indicator has no data to display, the default tooltip must be used instead. Maybe you could view the "default tooltip" as a status that is always linked to the tooltip indicator, or it could even show up in the tooltip indicator's "Statuses" tab, so you can disable it there if you do not want do display any default unit tooltip information.

  • michaelsp posted a comment Jan 10, 2019

    The problem is: the default behaviour (even in old Grid2 versions, before the tooltip indicator thing) is to display the tooltip only when out of combat.

     

    That is the reason for adding the  "Always show unit tooltips out of combat" option, and the reason to not link  the "name" status by default, to maintain the default behaviour. So anyway in a new Grid2 installation the default configuration must be changed, in old versions: changing "OOC" to "Always" in a select dropdown box, in new versions: assigning the "name" status to the tooltip indicator.

     

    Without this extra option, we will lose functionality too (the posibility to display the unit tooltip only in combat, and to display different things when in combat).


    Edited Jan 10, 2019
  • Kezo_ posted a comment Jan 10, 2019

    I see, then I probably enabled tooltips in combat years ago and didn't remember this. So linking the "name" status is the intended way to enable default tooltips in combat?

  • michaelsp posted a comment Jan 10, 2019

    Yes, in your case, to always display the unit name tooltip (in combat and out of combat), the setup will be:

     

    1. Link "name" status to the tooltip indicator.

    2. "Show statuses in Tooltip" => Always (to display name status in all cases: in combat and out of combat)

    3. "Always display unit tooltip information when Out of Combat" => Unchecked (because  this option becomes redundant)

     

    The third option is the problematic option, added only because the indicators<>statuses system does not allow to define different statuses for combat/out of combat conditions, you can "uncheck" and ignore this third option.


    Edited Jan 10, 2019
  • Kezo_ posted a comment Jan 10, 2019

    Okay, this solves my issue then, even though I still think it's a very unintuitive way to do this. Also, I assumed linking the "name" status would actually display the player name in the tooltip, as it does with text indicators, which makes this even more confusing. As for the third option becoming redundant, can't you maybe integrate this option into the first dropdown, so you would have six options instead of four:

     

    Never

    Always

    In Combat

    In Combat, Unit Tooltip Out of Combat

    Out of Combat

    Out of Combat, Unit Tooltip In Combat

  • michaelsp posted a comment Jan 11, 2019

    I changed the configuration of the tooltip indicator in revision 858, now the default setup must be more intuitive (i wish).

    In your case, you can uncheck the new option "Enable Advanced Tooltips", disabling this option, the configuration becomes more simple (the option is disabled by default in new setups).


    Edited Jan 11, 2019
  • michaelsp removed a tag Declined Jan 11, 2019
  • michaelsp added the tags Enhancement Fixed Jan 11, 2019
  • Kezo_ posted a comment Jan 12, 2019

    Awesome, thanks!

  • michaelsp closed issue Jan 12, 2019

To post a comment, please login or register a new account.