r845-alpha freezes the game a few seconds when using raid CDs #616


  • Fixed
  • Waiting
  • Started
Closed
  • kunlong created this issue Nov 15, 2018

    It seems r845-alpha freezes the game a few seconds with the following situations:

    1. using raid CDs applying a buff that is being tracking

    2. normal raid size like 20 ppl (in 5 man dungeon it seems fine)

     

    I tried holy and discipline priest in raid. When i used Holy Word: Salvation which gives everyone 2 buffs (Renew and Pray of Mending) in my tracking list, it caused the game client to freeze for a few seconds. In discipline when I used Evangelism to extend Atonements or even doing raid healing it caused the freezing as well. 

     

    Also it seems some Raid Debuffs are not being shown correctly even it is set to be shown.

     

    I switched back to r838 and the problems are gone. I'm pretty sure r842 and r843 should be fine since if my memory is correct I used them in last week's raid. Not sure about r844 because I don't have a chance to test it.

     

    I'm guessing you are changing the way to track buffs/debuffs in the new alpha version? You probably knew this already. Weakaura 2 recently changed the way to track buffs to make it more efficient: https://www.patreon.com/posts/22272340. It could be a good reference.

     

     

  • kunlong edited description Nov 15, 2018
  • michaelsp posted a comment Nov 15, 2018

    I cannot reproduce this problem, maybe is a priest issue, or not related to Grid2.

    Grid2 has not the weakauras problem, Grid2 auras code does not look for auras using AuraByName.

  • michaelsp added a tag Waiting Nov 15, 2018
  • kunlong posted a comment Nov 15, 2018

    I'll test it more and let you know the result.

  • kunlong posted a comment Nov 16, 2018

    I'm trying to reproduce this problem in LFR but it seems the problem is gone. I'll keep testing and if i see the problem again and with more details i'll get back to you.

     

    Since i'm already here I would like to report a little tiny bug about readycheck:

     

    As you can see there is a "Not Ready" mark on grid 2 but if you look at the system's default raid frame the rogue is ready. This happens in 5 man dungeon as well. The bug is been there for a few weeks but i figured its not a big deal so I didn't report it.

  • kunlong posted a comment Nov 16, 2018

    I read a few posts in wow's forum and there were some players had the same issues as mine. Its confirmed that is due to server issue and MAC client made it a little worse. MAC client got a few small upgrades and now the clutter is gone. Sorry about my confusing report and thank you for your great work on Grid2.

  • michaelsp added a tag Declined Nov 19, 2018
  • michaelsp closed issue Nov 19, 2018
  • GlaydeMoomins posted a comment Nov 19, 2018

    I had to roll back to a previous version, it was giving a slight delay whenever I put out a fresh lifebloom.

     

    Once I had one on someone and refreshed or moved to a different person, it was fine, but anytime I tried to put out a new lifebloom, it stuttered on me. Issue vanished when I reverted to the previous version.

     

     

  • kunlong posted a comment Nov 21, 2018

    Im sorry I thought the issue is gone but I was wrong. This problem remains in the following situations:

    1. using raid CDs applying a buff that is being tracking

    2. normal raid size like 20 ppl (in 5 man dungeon it seems fine)

     

    Last time when I tested it in LFR I couldn't reproduce the problem. It was  because I was using protection paladin instead of a healer that can apply healing buffs on the whole raid team.

     

    When i used Holy Word: Salvation which gives everyone 2 buffs (Renew and Pray of Mending) in my tracking list, it caused the game client to freeze for a few seconds.

     

    When I'm not tracking any buff from Divine Hymn, it doesn't cause any trouble. But when I put the buff "Divine Hymn" into tracking list it will freeze the game for a few seconds every time when I use divine hymn.

     

    When I use Power Word: Radiance to apply atonements, the freezing duration is short -- only about 0.2~0.4 second since the spell only apply atonements on 5 players instead of the whole raid team. It's probably unnoticeable if you have a very high performance computer. 

     

    When I reverted to r844 version this problem is gone.

  • michaelsp reopened issue Nov 28, 2018
  • michaelsp posted a comment Nov 28, 2018

    Try r847-alpha, this version maybe solve the issue.

  • kunlong posted a comment Nov 28, 2018

    Just tested it in LFR as a priest healer and the issue is gone. Thank you very much! Do you mind if I ask what caused that issue?

  • michaelsp removed a tag Declined Nov 29, 2018
  • michaelsp added a tag Started Nov 29, 2018
  • michaelsp posted a comment Nov 29, 2018

    I replaced all lua timers with timers directly managed by the game, because in theory is more efficient, C code is faster than LUA code, but the blizzard code has some weird bug or limitation, and in some circunstances, the game is absurdy slow starting a timer, like half million times more slow,  instead of 0.1 milliseconds, the game some times needs several seconds to start a timer.

    The issue is hard to debug because is a problem  in blizzard code, game code accesible only to blizzard developers, and i cannot easy reproduce de problem in my computer, i finally could force some delay starting hundred of timers at once (when the addon normally only uses 3 o 4 timers)


    Edited Nov 29, 2018
  • kunlong posted a comment Nov 29, 2018

    Thank you for your explanation.

    BTW the tiny readycheck bug is back in r847. It's always the last person who choose "ready" will be shown as "not ready".


    Edited Nov 29, 2018
  • michaelsp posted a comment Nov 30, 2018

    I cannot reproduce the readycheck bug and i tried really very hard. i made some minor changes in r848 but i dont think this version will fix your issue, because the programing logic inside the status is the same, this has not changed in ten years, i really have no idea how this status can fail.

  • kunlong posted a comment Nov 30, 2018

    I did a little more tests and it seems it's normal as long as I use "Icon" to show readycheck status. And the bug shows up when I use "Icons List" to show the readycheck status. It's always the last person who choose "ready".

     

    The 1st pic here is using "Icon" on the very left side and "Icons List" in the middle of the frame.

     

    The 2nd pic here is using only "Icons List" in the middle of the frame.

     

     

    Here is a link of my profile in case you need it.

    https://www.dropbox.com/s/s9vjow0ss5zeqlr/pallyTank.profile?dl=0

  • michaelsp posted a comment Nov 30, 2018

    Much better now, thanks for the tests, its a problem in icons indicator,  it was main designed to display buffs / debuffs, but people tend to use and configure the addon in many creative ways XD.

    The indicator have some  tricky optimizations  to alleviate the cpu usage (because they are more cpu intensive than simple icon indicators), one of this optimizations is breaking the readycheck status logic. Umm, i have to review all non aura statuses, some other statuses could be malfunctioning too with icons indicators, another cheap fix is  to not allow to link non aura statuses to icons indicators :P.

     

    Update: Version r849 must fix the readycheck issue.


    Edited Nov 30, 2018
  • kunlong posted a comment Nov 30, 2018

    Thank you for the informations and the updates. 

  • michaelsp closed issue Dec 1, 2018
  • michaelsp added a tag Fixed Dec 1, 2018

To post a comment, please login or register a new account.