BFA compatibility #28


  • New
  • Fixed
  • Patch
Closed
  • Forge_User_30391701 created this issue Jul 19, 2018

    BFA brings some API changes - one of the changes is renaming UNIT_POWER to UNIT_POWER_UPDATE. This leads to LUA errors while registering and mana bar updates are not working anymore.

    The (easy) fix for this is to replace UNIT_POWER  with UNIT_POWER_UPDATE in
    GridMBStatus:OnStatusEnable() and GridMBStatus:OnStatusDisable() in GridStatusMana.lua

  • Forge_User_30391701 added a tag New Jul 19, 2018
  • Forge_User_30391701 added a tag Patch Jul 19, 2018
  • Forge_User_71034824 posted a comment Jul 26, 2018

    Thanks for the detailed report and sorry for the late reply! I will try to add your changes when I get home this evening. However, since I am not actively playing anymore I can't test whether it works. Therefore it would be nice if you (and/or someone else) could test the new alpha when I commit it.

  • Forge_User_71034824 posted a comment Jul 27, 2018

    I pushed the fix to the repository. Ccan be found at

    https://www.wowace.com/projects/grid-mana-bars/files/2593395

     

    Could someone please try if it works?

  • Forge_User_30391701 posted a comment Jul 28, 2018

    Tested it with the Grid BFA version from Attict (https://github.com/Attict/Grid-Full). Works like a charm, thanks :)

  • Forge_User_71034824 posted a comment Aug 2, 2018

    Thank you. I tagged it as the new release.

     

    Thanks again for providing the fix!

  • Forge_User_71034824 added a tag Fixed Aug 2, 2018
  • Forge_User_30391701 closed issue Aug 2, 2018
  • Forge_User_30391701 posted a comment Aug 2, 2018

    closed


To post a comment, please login or register a new account.