Tracking of paladin Avenging Wrath broken #175


Open
  • aza547 created this issue May 19, 2021

    As the title.

     

    I suspect there is some custom handling for avenging wrath given that they can use the 2min CD to gain it, or they can gain it from a talent (holy)/honor talent (ret) proc.

     

    However it just doesn't work entirely. If a paladin pops wings, it continues to show its ready.

     

    I'm not familiar with the code, but I think the tracking should be:

    - on Avenging wings spell cast success, trigger 2 min CD cooldown tracker

    - ignore any wings procs (they don't send a combat log event for spell cast success to the combat log)

     

    This certainly happens for enemy rets, I'm not sure if it happens for holy, I suspect it does. 

     

    Thanks!

  • Vendethiel posted a comment May 20, 2021

    > - ignore any wings procs (they don't send a combat log event for spell cast success to the combat log)

     

    That's not how they're tracked. They're tracked based on duration when an AURA_APPLIED event is received.

  • aza547 posted a comment May 20, 2021

    Right, so I suppose that's the source of the issue? Tracking AURA_APPLIED catches the case they cast wings, and the case where it procs. 

     

    I don't think it makes sense to attempt to track the proc at all, in the case of holy it's totally random, in the case of ret it's based on how much they get crit 50 times or so.

     

    If it was tracked by SPELL_CAST_SUCCESS that would solve the problem. Perhaps that's too much work to do if it's outwith the pre-existing framework - but it seems wrong to offer tracking of Avenging Wrath if it is just broken. 

     

    Thanks

  • Vendethiel posted a comment May 20, 2021

    I know how the proc works. I'm saying it's explicitly trying not to track the proc, it just ends up doing it, and there's specific code in place to do that.

     

    If it was tracked by SPELL_CAST_SUCCESS that would solve the problem. Perhaps that's too much work to do if it's outwith the pre-existing framework

    Guess I could try that too. Thanks for the tip.

     

    but it seems wrong to offer tracking of Avenging Wrath if it is just broken.

    This honestly feels like a cheapshot. I spent time working on this, I put effort into making sure it did. Turns out there are some bugs left, but the report would've been just as helpful without that bit :).

  • aza547 posted a comment May 21, 2021

    Not intended as cheap shot, I very much appreciate the great addon and all the work it takes to maintain it. Poor wording from me - sorry!

     

    Thanks for the consideration. 


    Edited May 21, 2021
  • aza547 posted a comment May 21, 2021

    Actually I failed to understand what you wrote above and thought you were stating that this would just not work at all (I missed the bit about checking the duration). Had a quick look at the code and couldn't see any obvious reason why it's broken.

     

    This looks sensible, in cooldowns_paladin.lua:

     

    -- Avenging Wrath--

    LCT_SpellData[31884] = {

    class = "PALADIN",

    offensive = true,

    defensive = true,

    duration = 20,

    cooldown = 120, 

    cooldown_starts_on_aura_duration = true,

    }

  • Vendethiel posted a comment Jun 28, 2021

    I'm also interested in whether auto-dark (the DH legendary) has an event it doesn't send that the "normal" one doesn't. I guess I could also check that the DH has the auto-dark debuff.


To post a comment, please login or register a new account.