Trinket tracking #104


Closed
  • aza547 created this issue Nov 1, 2020

    Hello!

     

    Love your addon, and would like to keep using it in SL. 

     

    I think the trinket tracking no longer works as trinkets are now an item rather than an honor talent. 

     

    Is this something you're aware of? I wondered if it's now more complex to see the difference between a rele player and a trinket player - as I expect there was previously some API call to tell this that may no longer exist? 

     

    Are you planning a fix for this? 

     

    Thanks,

    Alex

     

     

     

  • Vendethiel posted a comment Nov 2, 2020

     That seems to work sometimes, and other times... Not so much.

     

    Need to take a look at what Gladius and the default UI are doing, but I have neither a sub nor SL, so that'll be very theoretical.

  • aza547 posted a comment Nov 2, 2020

    Ah - I've not noticed it work at all, the only time I've seen trinkets actually showing a cooldown is when a racial trinket with a shared cooldown as triggered it, and I've never seen a rele icon pop up. Let me know if I can help with any info. I'm not really familiar with WoW addon code, or I'd try find a fix myself.  

     

    Thanks - hope you can solve it! 

  • SkiaTheShade posted a comment Nov 2, 2020

    I'm having the same issue here. Sometimes it works and sometimes it doesn't. It mostly doesn't work, though.

     

    I love GladiusEx so I hope it is easy to solve! Great work with this addon!

  • Vendethiel posted a comment Nov 3, 2020

    Do either of you use ElvUI by any chance? I think it might disable a bit of code necessary for this.

  • AVB10 posted a comment Nov 3, 2020

    Hello!

     

    I love this addon and trinket displaying in pre patch was big issue for me, so i tried to fix it by my self. For me, it works pretty fine now, i just edited 1 file here: GladiusEx->libs->LibCooldownTracker-1.0->cooldowns_items.lua. I removed Honorable Medallion since it no longer exist and changed the trinket id's with the new ones. I also added Stoneform and Fireblood abilities to EMFH and WOTF, so they will now share cooldowns (30 second) with trinket and adapt. I played around 50 games after this changes and all of them worked fine. I think that the only 1 thing missing. If enemy player is not playing any pvp trinkets, normal ui does not show anything on the place where pvp trinket should be. But gladiusex just shows gladiators medallion even if player is not playing any pvp trinket. For me its not an issue, but i think that it would be great if it can be changed. I have no idea how to do this, i guess you have to know the code a bit better.

    https://gofile.io/d/9CLaod - Here is edited addon.

     

    P.S. I'm not using gladiusex for team frames, only for enemy team, so i guess you have to test it. 

     

    Sorry for my english :)


    Edited Nov 3, 2020
  • SkiaTheShade posted a comment Nov 4, 2020

    I was using ElvUI before the Shadowlands Pre Patch, but I'm no longer using it and haven't been for the past few weeks.


    Edited Nov 4, 2020
  • aza547 posted a comment Nov 4, 2020

    I've never used ElvUI

  • Vendethiel closed issue Nov 6, 2020
  • Vendethiel posted a comment Nov 6, 2020

    Fixed, will be in the next release.

  • aza547 posted a comment Nov 7, 2020

    Awesome - thanks <3


To post a comment, please login or register a new account.