Add option to hide tillers with exalted/best friend reputation #4


  • Enhancment
  • Accepted
  • Enhancement
Open
Assigned to myrroddin
  • mishikal1 created this issue Dec 25, 2012

    What steps will reproduce the problem?
    1.  Become exalted/best friends with a tiller
    2. The tiller is still listed

    There's no reason to keep doing the daily for a tiller once they are exalted.  Please add an option to hide tillers where rep has been maxed out.

  • mishikal1 added the tags New Enhancment Dec 25, 2012
  • bsmorgan posted a comment Dec 28, 2012

    See my latest patch attached to Ticket 2, "Add coordinates for non-Halfhill locations". I've added this "feature" to my patch.


    Edited Dec 28, 2012
  • mishikal1 posted a comment Dec 31, 2012

    Nice, thanks!

  • Myrroddin removed a tag New Jan 22, 2013
  • Myrroddin added a tag Accepted Jan 22, 2013
  • Myrroddin removed a tag Defect Jan 22, 2013
  • Myrroddin added a tag Enhancement Jan 22, 2013
  • rainrider posted a comment Apr 1, 2013

    @bsmorgan: Go

    Hiding best friends could be done easier by using the 9th return of GetFriendshipReputation which is nil for best friends.

    Find:

    			for i = 1, #npcs do
    				local npc = npcs[i]
    				if not npc.item then
    					npc.item = GetItemInfo(npc.itemID)
    				end
    				if not IsQuestFlaggedCompleted(npc.questID) then
    

    and replace by:

    			for i = 1, #npcs do
    				local npc = npcs[i]
    				local isNotBestFriend = select(9, GetFriendshipReputation(npc.factionID))
    				if not npc.item then
    					npc.item = GetItemInfo(npc.itemID)
    				end
    				if not IsQuestFlaggedCompleted(npc.questID) and isNotBestFriend then
    

    The code in based on the currently available addon version and not on the changes from bsmorgan


    Edited Apr 1, 2013

To post a comment, please login or register a new account.