r1962 MM Hunter Tooltip miscalc/miscalc on target #288

  • Defect
  • New
Assigned to angosia
  • _ForgeUser1327937 created this issue May 21, 2013

    What is your Race, Class and Level?
    Human, Hunter, 82

    What action bar mod do you use, if any?
    Bartender 4

    What is the expected output? What do you see instead?
    Average total damage expected, but is calculated/displayed wrong (when a target is choosen; see below).

    If this is an accuracy issue, what is your exact spec and your damage attributes? (For spells SP, for melee abilities AP/RAP, weapon etc.). Armory links are helpful.
    My spec is marksman, but this bug is independent of attributes.

    What version of DrDamage are you using?

    Do you have an error log of what happened?

    Please provide any additional information below.

    As marksman hunter you have 3 passive dps gains: Wild Quiver (mastery), Piercing Shots and Careful Aim.

    Wild Quiver is currently calculated/displayed correctly on shots, but wrongly added to Serpent Sting aswell.
    Piercing Shots is currently wrongly calculated/displayed for all shots, aswell as Serpent Sting and Explosive Trap instead of only for Aimed Shot, Steady Shot and Chimeara Shot.
    Careful Aim is currently wrongly calculated/displayed for all skills for targets above 80% health instead of only applying to Steady Shot and Aimed Shot for targets above 80% health.

  • _ForgeUser1327937 added the tags New Defect May 21, 2013
  • angosia posted a comment May 21, 2013

    It looks like the code was there, in the old talents section - updated for Mists. However, those options didn't seem to have worked. So, I reworked it to a consistent model we've used before. Let me know if that works. This is in r1964.

  • angosia unassigned issue from Forge_User_71657876 May 21, 2013
  • angosia self-assigned this issue May 21, 2013
  • _ForgeUser1327937 posted a comment May 21, 2013

    Hmm, Careful Aim and Piercing Shot seem fixed, however Wild Quiver still appears in the tooltip of Serpent Sting. Good job on the rest so far :) ty

    Edited May 21, 2013
  • angosia posted a comment May 21, 2013

    @Goddamnedmaster: Go

    Hmm. I'm not sure if I can fix it, but I'll try. I've added additional logic to Wild Quiver. But, what was there before should have worked, so I'm not entirely sure this will fix it if the previous did not.

    Beyond that, it may require additional code if r1965 doesn't work.

  • _ForgeUser1327937 posted a comment May 21, 2013

    Hm, nope, didn't fix it. Thanks for the try anyway..I think one can live with it for now Maybe you will find and fix the error later. Will report any further issues when I find some.

  • angosia posted a comment May 21, 2013

    @Goddamnedmaster: Go

    I'll look into it probably tomorrow. I suspect I know what the problem is. As for what it will take to fix... heh. If I can't figure it out, I'll nag Gagorian.

To post a comment, please login or register a new account.