Error with "GarrisonMissionAlertSystem" #113


  • New
  • Defect
Open
Assigned to esembe
  • user_767395 created this issue Jul 24, 2016

    What steps will reproduce the problem?
    Log in with the Addon is active

    What version of the product are you using?
    1.9.0

    Do you have an error log of what happened?

    1x FrameXML\AlertFrames.lua:291: attempt to index global 'GarrisonMissionAlertSystem' (a function value)
    FrameXML\AlertFrames.lua:291: in function <FrameXML\AlertFrames.lua:203>
    
    Locals:
    self = AlertFrame {
     AddAlertFrameSubSystem = <function> defined @FrameXML\AlertFrames.lua:337
     OnLoad = <function> defined @FrameXML\AlertFrames.lua:179
     UpdateAnchors = <function> defined =[C]:-1
     anchorPrioritiesDirty = true
     AddJustAnchorFrameSubSystem = <function> defined @FrameXML\AlertFrames.lua:325
     SetSubSustemAnchorPriority = <function> defined @FrameXML\AlertFrames.lua:345
     OnEvent = <function> defined @FrameXML\AlertFrames.lua:203
     AddSimpleAlertFrameSubSystem = <function> defined @FrameXML\AlertFrames.lua:329
     AddAlertFrame = <function> defined @FrameXML\AlertFrames.lua:371
     alertFrameSubSystems = <table> {
     }
     CleanAnchorPriorities = <function> defined @FrameXML\AlertFrames.lua:354
     0 = <userdata>
     AddQueuedAlertFrameSubSystem = <function> defined @FrameXML\AlertFrames.lua:333
    }
    event = "GARRISON_MISSION_FINISHED"
    validInstance = true
    _ = "FW Horde Garrison Level 3"
    instanceType = "party"
    followerTypeID = 1
    missionID = 120
    missionFrame = GarrisonMissionFrame {
     0 = <userdata>
     OnClickViewCompletedMissionsButton = <function> defined @Blizzard_GarrisonTemplates\Blizzard_GarrisonMissionTemplates.lua:804
     OnDragStartMissionFollower = <function> defined @Blizzard_GarrisonTemplates\Blizzard_GarrisonMissionTemplates.lua:738
     OnLoadMainFrame = <function> defined @Blizzard_GarrisonUI\Blizzard_GarrisonMissionUI.lua:28
     NextMission = <function> defined @Blizzard_GarrisonTemplates\Blizzard_GarrisonMissionTemplates.lua:825
     SetupCompleteDialog = <function> defined @Blizzard_GarrisonUI\Blizzard_GarrisonMissionUI.lua:56
     SetupMissionList = <function> defined @Blizzard_GarrisonUI\Blizzard_GarrisonMissionUI.lua:20
     CheckCompleteMissions = <function> defined @MasterPlan\MissionsUI.lua:3640
     TopBorder = <unnamed> {
     }
     Bottom = <unnamed> {
     }
     ShowMissionStage = <function> defined @Blizzard_GarrisonUI\Blizzard_GarrisonMissionUI.lua:210
     BotRightCorner = <unnamed> {
     }
     SetEnemies = <function> defined =[C]:-1
     OnDragStopFollowerButton = <function> defined @Blizzard_GarrisonTemplates\Blizzard_GarrisonMissionTemplates.lua:732
     UpdateMissionParty = <function> defined @Blizzard_GarrisonUI\Blizzard_GarrisonMissionUI.lua:377
     MissionCompleteBackground = <unnamed> {
     }
     OnEventMainFrame = <function> defined @Blizzard_GarrisonUI\Blizzard_GarrisonMissionUI.lua:91
     RightBorder = <unnamed> {
     }
     UpdateRewards = <function> defined @Blizzard_GarrisonUI\Blizzard_GarrisonMissionUI.lua:678
     UpdateStartButton = <function> defined @Blizzard_GarrisonTemplates\Blizzard_GarrisonMissionTemplates.lua:464
     HasMission = <function> defined @Blizzard_GarrisonTemplates\Blizzard_GarrisonMissionTemplates.lua:99
     ClearMouse = <function> defined @Blizzard_GarrisonUI\Blizzard_GarrisonMissionUI.lua:406
     OnClickFollowerPlacerFrame = <function> defined @Blizzard_GarrisonTemplates\Blizzard_GarrisonMissionTemplates.lua:703
     TopRightCorner = <unnamed> {
     }
     SetMissionCompleteNumEncounters = <function> defined @Blizzard_GarrisonTemplates\Blizzard_GarrisonMissionTemplates.lua:1050
     MissionTab = <unnamed> {
     }
     OnShowMainFrame = <function> defined @Blizzard_GarrisonUI\Blizzard_GarrisonMissionUI.lua:136
     SetPartySize = <function> defined @Blizzard_GarrisonUI\Blizzard_GarrisonMissionUI.lua:224
     ResetMissionCompleteEncounter = <function> defined @Blizzard_GarrisonUI\Blizzard_GarrisonMissionUI.lua:478
     SelectTab = <function> defined @Blizzard_GarrisonUI\Blizzard_GarrisonMissionUI.lua:180
     FollowerList = GarrisonMissionFrameFollowers {
     }
     GetMissionPage = <function> defined @Blizzard_GarrisonTemplates\Blizzard_GarrisonMissionTemplates.lua:34
     SummaryTab = <unnamed> {
     }
     TitleText = <unnamed> {
     }
     OnHideMainFrame =
    

    Please provide any additional information below.
    Disable the Addon will prevent this error.

  • user_767395 added the tags New Defect Jul 24, 2016
  • user_767395 posted a comment Jul 24, 2016

    disable the RawHook's for "GarrisonMissionAlertSystem" and "GarrisonBuildingAlertSystem" fix this error temporary but also re-enable the Original Garrison Mission Alerts.

    core.lua -> line 1920

    self:RawHook("GarrisonMissionAlertSystem", true);
    

    core.lua -> line 1921

    self:RawHook("GarrisonBuildingAlertSystem", true);
    

    Maybe you should find another way to prevent the Original Garrison Mission Alerts not just overwrite the original function ^^

    EDIT
    Unregister the Event will not Work because some AddOns like Master Plan Re-Register it :/


    Edited Jul 31, 2016
  • barackstar posted a comment Jul 24, 2016

    @q3fuba: Go

    disabling those 2 lines in Broker_Garrison also fixes a conflict with ElvUI v10.09, which was causing the Quest/Objective Tracker frame to attach to the Minimap and not be movable.


    Edited Jul 24, 2016
  • esembe posted a comment Jul 24, 2016

    thank you - removed temporarily

  • user_767395 posted a comment Jul 31, 2016

    seems that i got a way to "Hide" the Alerts this way, maybe you need to test around with it so i will do the next days.

    GarrisonBuildingAlertFrame:HookScript("OnShow", function(self) self:Hide() end)
    GarrisonMissionAlertFrame:HookScript("OnShow", function(self) self:Hide() end)
    

    it's also a ugly way to just "Hide" the Frame "OnShow" but it looks like it's working... :D

    dont know you may also need to Hide this:

    GarrisonShipMissionAlertFrame
    

    but im not sure


    Edited Aug 28, 2016
  • user_767395 posted a comment Aug 28, 2016

    @smb: Go maybe you take a look on this:

    GarrisonBuildingAlertFrame:HookScript("OnShow", function(self) self:Hide() end)
    GarrisonMissionAlertFrame:HookScript("OnShow", function(self) self:Hide() end)
    GarrisonShipMissionAlertFrame:HookScript("OnShow", function(self) self:Hide() end)
    

    used it since you disabled the RawHook and it worked!


To post a comment, please login or register a new account.