WowAce

update for df ?

 Note: I am not the author, I’ve just used this addon forever and don’t really want to let it die yet.

So with the addition of the Reagent Pouch slot, Blizzard in their infinite wisdom decided to force the Reagent Pouch into slot 5 (0 is backpack, 1-4 are main bags) which forced the bank bags to go from 5 through 11, to 6 through 12.

They also added in a lot of “strict” parameter checks for API calls, which is why a lot of other errors started showing up.

I spent last night and a just a little bit today figuring out how to un-break the addon and get things showing up, and I have it working.

Here's a link that works at least for now to get my modified file :

https://cdn.discordapp.com/attachments/270679410565316629/1035329911222718564/BankItems.lua

I don't see any way to push my changes up to the author except this "Subversion" link on the "Source" tab, but I have no idea how to use that.

Just saw a button to add an attachment, so there's another option to get it.

THX !!!!!!!!

THX

it s works

i love you

Logged in just to say THANK YOU Centias!

Thank you Centias for fixing this. I was missing it greatly. Two problems with it though:

1. The minimap was enlarged. BankItems doesn't know the size of the new minimap. Therefore, placing the button is tricky - you can only put it on the left side of the minimap. All other positions are inside the display!

2. The script is somehow causing WoW to chew up application memory at an alarming rate. I've been playing for the last two days just fine but when I load this add-on, within about 30 seconds, the memory on my machine is gone and I'm getting notices that I've run out of "application memory".  There's one or more memory leaks somewhere in the add-on...

 1. Was able to mostly fix the minimap button alignment. You may need to go into the options and change the button radius because it is probably going to be something like 78 in your SavedVariables, but it needs to be something close to 110.

2. I have no idea how to help with the memory. I'm actually not having the same issue at all. Even opening as many windows as I can in the addon, searching for items with a lot of results like potions and ore, it doesn't even make it into the top 5 highest memory usage. You may want to wipe out your saved variable for the addon and starting fresh to see if that helps.

Awesome work Centias!

I was also mucking about with the addon, and I compared my mods to yours - we're very close.

I'm getting an empty Guild Bank - any ideas?  Did Blizzard mess with the guild bank interface... again?  :D

Also, some of the tiny buttons for Money, Equipped, etc are missing. I haven't been able to figure out why they're not showing anymore.

Summary of BankItems.lua changes in BankItems2.zip since last official release by the author.

• Added Centias mods that fixes BAGNUMBERS since Blizzard "stole" BagID 5, and new call to GetRecipeFixedReagentItemLink().
• Added default settings for variables bags and bagsShown for ContainerFrame1 - new UI will throw an exception if they don't exist.
• Removed VOID_STORAGE_OPEN/CLOSE event handling - it's now removed from the UI.
• Changed argument to SetUserPlaced() from nil to false - the argument needs to be boolean.
• Fixed issue where the little icons for Currency, Equipped Items, Auctions, and Mailbox were not shown.
• Fixed location of top-right Close buttons - they was a little off.
• Did the same fix as Centias and moved the minimap button and radius to correct size.
• Change calls from BlizzardOptionsPanel_CheckButton_Disable(object) to object:Disable().  Same for Enable.
• Change CheckButton frames to inherit from InterfaceOptionsCheckButtonTemplate instead of OptionsCheckButtonTemplate

Be careful with the Export and Search BankItems buttons. The "Group similar items" checkbox seems to break everything.

Re : Guild Bank not populating

This is a problem that I noticed is occurring with both BankItems and Bagnon, and I haven't been able to find any kind of reason why. There's no error, it just never updates the guild bank info. My BankItems is stuck holding data from 10/23.

If I could figure out why it's acting this way, I could have a fix for both. For now, I've had to turn off the guild bank frame for Bagnon and use the Blizzard default.

 WELP. I found a fix. And I hate it.

The event "GUILDBANKFRAME_OPENED" is never firing (I have no idea if there's a new event for this)

So isGuildBankOpen would never change
So BankItems_SaveGuildBankItems would always stop before it ever started and not save anything.

BUT HEY IT WORKS NOW. Yay. Gonna see in a bit if Bagnon is doing the same thing..

 I got a little bit hasty and commented out the "isGuildBankOpen" stuff, which worked, but I found a more proper solution to tracking the right event to check if it actually is open, and implemented that.

Super cool Centias.  You did some serious snooping.

My guild bank is now working in BankItems.  VERY COOL!

 I noticed some of my change went missing related to bringing in the new reagent pouch slot and moving the void storage button up to the smaller row went missing, so here's an updated version: https://cdn.discordapp.com/attachments/1035400811460706344/1037208136303530004/BankItems.zip

For some reason, the attachment post is now having an HTTP POST 500 error.

While I am grateful that this has been fixed, I'm having an issue opening my bags in game. When I go to click on the bags at the bottom right, it doesn't work. Even when I use B to open the bags, I'm not able to click on anything inside my bags

 nawlinsguy1980

Make sure you have something to grab any errors you're getting.

And you may have a setting enabled that others do not, that is preventing it from opening.
Also make sure any other addons that may interact with bags are not the culprit (Bagnon has not really had a solid update and I've been trying to find fixes for that too).

@Centias.@BitBasher - just wanted to say thanks for the effort (it's the one addon I will never be able to do without), really appreciate you stepping up and helping us!

 It was pointed out in a comment that the addon stops working in 10.0.2 (beta or PTR), so I have done some work on that front.

10.0.2 apparently removed "OnTooltipSetItem" for tooltip frames.

 With some work I was able to find some small success, but I haven't been able to figure out the next part:

I added a small go-between function :

function OnTooltipSetItem(self, tooltip, data)
   BankItems_AddTooltipData(self, tooltip, data)
end

I commented out all of function BankItems_Hooktooltip and replaced it with the single line :

TooltipDataProcessor.AddTooltipPostCall(Enum.TooltipDataType.Item, OnTooltipSetItem)

Then things sort of don't make sense to me. It shows the line in the tooltip once, for less than a second, then removes it and never shows it again.

At the start of function BankItems_AddTooltipData, if I remove " or self.BankItemsDone " it will work but add the line for where items are 7 times.
I can't seem to figure out how to make it only show once.

I just realized I'm kind of a dummy and not understanding how the new tooltip functions work. Current iteration of BankItems loops through tooltip frames and then tries to hook all of them. That whole process can be simplified down to adding calls for each type of tooltip, I just have to figure out how to do the rest of them.

Using the above changes, basically all of function BankItems_HookTooltips() can be simplified down to

function BankItems_HookTooltips()
   TooltipDataProcessor.AddTooltipPostCall(Enum.TooltipDataType.Item, OnTooltipSetItem)

end

but with a TooltipDataProcessor.AddTooltipPostCall(...) line for each type of tooltip. I'm trying to figure out Currency right now, since that seems next most relevant.

Edit:
This might even work with just hooking into all tooltips using
   TooltipDataProcessor.AddTooltipPostCall("ALL", OnTooltipSetItem)
and only updating the relevant ones. It seems to work for items, but I still have nothing coming up for currency.

1029x Interface/AddOns/BankItems/BankItems.lua:6417: bad argument #1 to 'strmatch' (string expected, got nil)
[string "=[C]"]: ?
[string "@Interface/AddOns/BankItems/BankItems.lua"]:6417: in function `BankItems_Generate_SelfItemCache'
[string "@Interface/AddOns/BankItems/BankItems.lua"]:1022: in function <Interface/AddOns/BankItems/BankItems.lua:938>

Locals:
(*temporary) = nil
(*temporary) = "item:(%d+)"
(*temporary) = "string expected, got nil"

 Not really sure why this broken suddenly, but there is a quick fix : visit the bank once if you get the error.
I'm also posting an updated file that should fix that error.

Good work, Centias.

I've got BugGrabber and BugSack installed, and your last release is constantly throwing up errors.

I'll see if I can figure out what's going wrong on the weekend.

Update, saw your post from 2 hours ago, it's now working!

Message: Interface/AddOns/BankItems/BankItems.lua:6422: table index is nil
Time: Wed Nov 16 16:52:01 2022
Count: 5
Stack: Interface/AddOns/BankItems/BankItems.lua:6422: table index is nil
[string "@Interface/AddOns/BankItems/BankItems.lua"]:6422: in function `BankItems_Generate_SelfItemCache'
[string "@Interface/AddOns/BankItems/BankItems.lua"]:996: in function <Interface/AddOns/BankItems/BankItems.lua:938>

Locals: temp = nil
uniqueItem = nil
data = <table> {
136924 = <table> {
}
21309 = <table> {
}
127748 = <table> {
}
}
equippedBags = <table> {
}
bankPlayer = <table> {
1 = <table> {
}
2 = <table> {
}
3 = <table> {
}
4 = <table> {
}
5 = <table> {
}
6 = <table> {
}
7 = <table> {
}
8 = <table> {
}
9 = <table> {
}
10 = <table> {
}
11 = <table> {
}
12 = <table> {
}
13 = <table> {
}
14 = <table> {
}
15 = <table> {
}
16 = <table> {
}
17 = <table> {
}
18 = <table> {
}
19 = <table> {
}
20 = <table> {
}
21 = <table> {
}
22 = <table> {
}
23 = <table> {
}
24 = <table> {
}
25 = <table> {
}
26 = <table> {
}
27 = <table> {
}
28 = <table> {
}
Bag102 = <table> {
}
Bag105 = <table> {
}
Bag101 = <table> {
}
Bag12 = <table> {
}
Bag103 = <table> {
}
Bag4 = <table> {
}
bankTOC = 100002
Bag2 = <table> {
}
Bag9 = <table> {
}
Bag11 = <table> {
}
Bag7 = <table> {
}
NumBankSlots = 7
Bag100 = <table> {
}
Bag10 = <table> {
}
Bag8 = <table> {
}
money = 49392729
VerNum = 9000203
Bag3 = <table> {
}
faction = "Horde"
bankVerNum = 9000203
Bag0 = <table> {
}
Bag1 = <table> {
}
location = "Orgrimmar"
Bag104 = <table> {
}
TOC = 100002
Bag6 = <table> {
}
}
(for index) = 10
(for limit) = 28
(for step) = 1
num = 10
(*temporary) = <table> {
}
(*temporary) = <table> {
}
(*temporary) = <table> {
}
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "table index is nil"
selfPlayer = <table> {
1 = <table> {
}
2 = <table> {
}
3 = <table> {
}
4 = <table> {
}
5 = <table> {
}
6 = <table> {
}
7 = <table> {
}
8 = <table> {
}
9 = <table> {
}
10 = <table> {
}
11 = <table> {
}
12 = <table> {
}
13 = <table> {
}
14 = <table> {
}
15 = <table> {
}
16 = <table> {
}
17 = <table> {
}
18 = <table> {
}
19 = <table> {
}
20 = <table> {
}
21 = <table> {
}
22 = <table> {
}
23 = <table> {
}
24 = <table> {
}
25 = <table> {
}
26 = <table> {
}
27 = <table> {
}
28 = <table> {
}
Bag102 = <table> {
}
Bag105 = <table> {
}
Bag101 = <table> {
}
Bag12 = <table> {
}
Bag103 = <table> {
}
Bag4 = <table> {
}
bankTOC = 100002
Bag2 = <table> {
}
Bag9 = <table> {
}
Bag11 = <table> {
}
Bag7 = <table> {
}
NumBankSlots = 7
Bag100 = <table> {
}
Bag10 = <table> {
}
Bag8 = <table> {
}
money = 49392729
VerNum = 9000203
Bag3 = <table> {
}
faction = "Horde"
bankVerNum = 9000203
Bag0 = <table> {
}
Bag1 = <table> {
}
location = "Orgrimmar"
Bag104 = <table> {
}
TOC = 100002
Bag6 = <table> {
}
}
newTable = <function> defined @Interface/AddOns/BankItems/BankItems.lua:2826
strmatch = <function> defined =[C]:-1
BankItems_createUniqueItem = <function> defined @Interface/AddOns/BankItems/BankItems.lua:6277
ipairs = <function> defined =[C]:-1
BAGNUMBERS = <table> {
1 = 0
2 = 1
3 = 2
4 = 3
5 = 4
6 = 5
7 = 6
8 = 7
9 = 8
10 = 9
11 = 10
12 = 11
13 = 12
14 = 100
15 = 101
16 = 102
17 = 103
18 = 104
19 = 105
}
format = <function> defined =[C]:-1
isBankOpen = true
pairs = <function> defined =[C]:-1
GetItemCount = <function> defined =[C]:-1
delTable = <function> defined @Interface/AddOns/BankItems/BankItems.lua:2833

Materials in the material storage are not counted - besides when i am not at a bank and I open BankItems the window of the material storage is empty

Got this new error when I visited my bank to deposit things, and kept going off as I left the bank

200x BankItems/BankItems.lua:4221: attempt to index local 'theItem' (a nil value)
[string "@BankItems/BankItems.lua"]:4221: in function `BankItems_SaveReagentBank'
[string "@BankItems/BankItems.lua"]:995: in function <BankItems/BankItems.lua:938>

Locals:
j = 7
validCount = 7
_ = nil
texture = 1044088
count = 1000
link = "|cff1eff00|Hitem:120945::::::::60:73:::::::::|h[Primal Spirit]|h|r"
itemPointer = <table> {
icon = 1044088
count = 1000
link = "|cff1eff00|Hitem:120945::::::::60:73:::::::::|h[Primal Spirit]|h|r"
}
(for index) = 8
(for limit) = 98
(for step) = 1
slot = 8
theItem = nil
(*temporary) = <function> defined =[C]:-1
(*temporary) = -3
(*temporary) = 8
(*temporary) = "attempt to index local 'theItem' (a nil value)"
selfPlayer = <table> {
1 = <table> {
}
2 = <table> {
}
3 = <table> {
}
4 = <table> {
}
5 = <table> {
}
6 = <table> {
}
7 = <table> {
}
8 = <table> {
}
9 = <table> {
}
10 = <table> {
}
11 = <table> {
}
12 = <table> {
}
13 = <table> {
}
14 = <table> {
}
15 = <table> {
}
16 = <table> {
}
17 = <table> {
}
18 = <table> {
}
19 = <table> {
}
20 = <table> {
}
21 = <table> {
}
22 = <table> {
}
23 = <table> {
}
24 = <table> {
}
25 = <table> {
}
26 = <table> {
}
27 = <table> {
}
28 = <table> {
}
Bag102 = <table> {
}
Bag105 = <table> {
}
Bag101 = <table> {
}
Bag4 = <table> {
}
Bag103 = <table> {
}
bankTOC = 100002
Bag12 = <table> {
}
Bag2 = <table> {
}
Bag9 = <table> {
}
Bag11 = <table> {
}
Bag1 = <table> {
}
Bag7 = <table> {
}
Bag100 = <table> {
}
Bag10 = <table> {
}
VerNum = 9000203
money = 52323892146
bankVerNum = 9000203
Bag3 = <table> {
}
faction = "Horde"
Bag5 = <table> {
}
Bag8 = <table> {
}
Bag0 = <table> {
}
NumBankSlots = 7
location = "Oribos"
Bag104 = <table> {
}
TOC = 100002
Bag6 = <table> {
}
}
newTable = <function> defined @BankItems/BankItems.lua:2826
ICON_ReagentBank = "Interface\Icons\INV_Enchant_ShardShadowfrostLarge"
NUM_REAGENTBANKGENERIC_SLOTS = 98
GetContainerItemInfo = <function> defined =[C]:-1
slotAdjust = <table> {
104 = <table> {
}
105 = <table> {
}
}
delTable = <function> defined @BankItems/BankItems.lua:2833
reagentBankPageSize = 28
pages = <table> {
ReagentBank = 1
AH = 1
Void = 1
Mail = 1
Currency = 1
}
bankPlayer = nil
BankItems_RBFrame = BankItems_RBFrame {
0 = <userdata>
TitleText = FontString {
}
RightBorder = Texture {
}
LeftBorder = Texture {
}
TitleBg = Texture {
}
BottomBorder = Texture {
}
TopTileStreaks = Texture {
}
BotRightCorner = Texture {
}
TopBorder = Texture {
}
CloseButton = Button {
}
BotLeftCorner = Texture {
}
TopLeftCorner = Texture {
}
Bg = Texture {
}
TopRightCorner = Texture {
}
}
BagContainerAr = <table> {
}
BagButtonAr = <table> {
}

 TYVM for reviving my favourite bank addon <3 keep up the good work!

Anyone still working on this add-on?  If so, the minimap button doesn't seem to know the size of the minimap. It's appearing inside the map instead of outside.

Thx.