WowAce

BankItems Version: 9.0.2.3

Game Version: 9.0.5

Description of Error:

The item tooltip for some currencies is missing the correct number of characters that actually have that currency.

For me 11 characters own Champion's Seals, but if I hover over any "Champion's Seal" only 4 characters are shown in the tooltip. Therefore the total number of seals shown, is also wrong.

I did some digging and found that the seals are correctly detected by the addon in both the "SavedVariables\BankItems.lua" and the currencies bag of the main addon window, but not the tooltip. I found the difference for the characters who show the seals in the tooltip and those who don't, to be the number of currencies the char actually has.

Fine (excerpt from "SavedVariables\BankItems.lua"):

{
	["count"] = 43,
	["icon"] = 236246,
	["link"] = "|cffffffff|Hcurrency:241:0|h[Champion's Seal]|h|r",
	}, -- [32]

Not fine:

{
	["count"] = 3,
	["icon"] = 236246,
	["link"] = "|cffffffff|Hcurrency:241:0|h[Champion's Seal]|h|r",
	}, -- [46]

For characters who own more than 32 currencies, the currencies with a higher index are placed onto the second page of the addons currencies bag, and are not counted correctly for the tooltip.

I looked at some other currencies (e.g. "Spirit Shard", "Mote of Darkness") which also show the same problem.

Steps to Reproduce Error:

Log into a character that has more than 32 currencies. Open the blizzard Character Info [C] >> currencies panel and point the cursor to one of the currencies further down than 32 (for example "Champion's Seal" or "Spirit Shard") and the tooltip won't show that the character owns the currency.

Thanks for this great addon

Psyco :D

OK, I think I fixed the bug.

I changed lines 6343 (ItemCache) and 6429 (SelfItemCache) from:

if bagNum == 101 or bagNum == 103 then

to:

if bagNum == 101 or bagNum == 102 or bagNum == 103 then

I don't know if this has some other effects, that I have yet to encounter, but it fixes the bug. Maybe a dev can take a look into it?