Billion is not parsed for AP rewards #17


  • Defect
Open
  • Kuhani created this issue Nov 1, 2017

    With AK 50, some quest rewards now go above 1 billion which is not parsed correctly.

     

    1.2 billion is shown as "12" in the quest log.

     

  • Kuhani added a tag Defect Nov 1, 2017
  • Wig0r posted a comment Nov 2, 2017

    Data.lua:
    Change

    local apStringValueTwo = {
    	--1.000.000
    	["enUS"] = "(%d*[%p%s]?%d+) million",
    	["enGB"] = "(%d*[%p%s]?%d+) million",
    

     To

    local apStringValueTwo = {
    	--1.000.000.000
    	["enUS"] = "(%d*[%p%s]?%d+) billion",
    	["enGB"] = "(%d*[%p%s]?%d+) billion",

     QuestFrame.lua

    Replace

    local function ArtifactPowerTruncate(power)
    	...
    end

     With

    local function ArtifactPowerTruncate(power)
    	-- return AbbreviateNumbers(power):lower()
    	if power >= 20000000000 then
    		return floor(power / 1000000000) .. "b"
    	elseif power >= 1000000000 then
    		return (floor(power / 100000000) / 10) .. "b"
    	elseif power >= 20000000 then
    		return floor(power / 1000000) .. "m"
    	elseif power >= 1000000 then
    		return (floor(power / 100000) / 10) .. "m"
    	elseif power >= 20000 then
    		return floor(power / 1000) .. "k"
    	elseif power >= 1000 then
    		return (floor(power / 100) / 10) .. "k"
    	else
    		return power
    	end
    end

     

     

     

     

     

  • Wig0r posted a comment Nov 2, 2017

    Data.lua

    Change

    local apValueMultiplierTwoLocal = (apValueMultiplierTwo[GetLocale()] or 1e6)

     to

    local apValueMultiplierTwoLocal = (apValueMultiplierTwo[GetLocale()] or 1e9)

     

  • Wig0r posted a comment Nov 2, 2017

    This is enGB and enUS, for other localizations, just adjust the part that corresponds to your language in 

    local apStringValueTwo = {
    	...
    }

    for the addon to recognize how billions are spelled/named in your language

  • Ermads posted a comment Nov 2, 2017

    Released an update let me know if it fixes the issue.

  • Wig0r posted a comment Nov 3, 2017

    Works on enUS/GB


To post a comment, please login or register a new account.