Skada Damage Meter

448 - Req: Data feed - Combat Indicator

Hi there, maybe you can add a Databroker feed that show for example "In Combat" and "Out of Combat" besides Personal DPS, Raid DPS and Personal Thread? Or maybe also you can add Combat Time as an extra feed?

i've done this by myself until you can integrate it by changed "Skada.lua at line 1892" from:

if selectedfeed ~= nil then
	local feedtext = selectedfeed()
	if feedtext then
		dataobj.text = feedtext
	end
end

to this:

if selectedfeed ~= nil then
	local feedtext = selectedfeed()
	if feedtext then
		dataobj.text = feedtext
	end
else
	if InCombatLockdown() then
		dataobj.text = "In Combat";
	else
		dataobj.text = "Out of Combat";
	end
end

but this isn't really clean, thanks ;)

User When Change
q3fuba Mar 08, 2016 at 16:14 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 1 comment
  • Avatar of q3fuba q3fuba Mar 09, 2016 at 12:05 UTC - 0 likes

    hi again, seems InCombatLockdown() does not fire on every PLAYER_REGEN_ENABLED and PLAYER_REGEN_DISABLED as described :/

    So i added an extra Frame for Register a Event in "Skada.lua at line 13":

    local InCombatFrame = CreateFrame("Frame")
    local InCombat
    InCombatFrame:RegisterEvent("PLAYER_REGEN_ENABLED")
    InCombatFrame:RegisterEvent("PLAYER_REGEN_DISABLED")
    InCombatFrame:SetScript("OnEvent", function(self, event, ...)
        InCombat = (event=="PLAYER_REGEN_DISABLED")
    end)
    

    and also edited the posted sugestion code to:

    if selectedfeed ~= nil then
    	local feedtext = selectedfeed()
    	if feedtext then
    		dataobj.text = feedtext
    	end
    else
    	if InCombat then
    		dataobj.text = "In Combat"
    	else
    		dataobj.text = "Out of Combat"
    	end
    end
    
  • 1 comment

Facts

Reported
Mar 08, 2016
Status
New - Issue has not had initial review yet.
Type
Enhancement - A change which is intended to better the project in some way
Priority
Medium - Normal priority.
Votes
0

Reported by

Possible assignees