You must login to post a comment. Don't have an account? Register to get one!

• 

  • Reply
  • #1

  avi90 Nov 06, 2014 at 23:04 UTC - 0 likes

  Hi, with the new combatlog event SPELL_ABSORBED (which fires at the same time as damage events with absorbs) you can track such absorbs. So I propose that you change your parsing of absorbs to something like this:

  local function SpellAbsorbed(timestamp, eventtype, srcGUID, srcName, srcFlags, dstGUID, dstName, dstFlags, ...)
  	local attackSpellID, attackSpellName, attackSpellSchool,
  		creditGUID, creditName, creditFlags, creditRaidFlags,
  		absorbSpellID, absorbSpellName, absorbSpellSchool,
  		amount
  
  	if select(11, ...) == nil then
  		-- meele hit (no attack spell info)
  		creditGUID, creditName, creditFlags, creditRaidFlags,
  			absorbSpellID, absorbSpellName, absorbSpellSchool,
  			amount = ...
  	else
  		-- spell hit
  		attackSpellID, attackSpellName, attackSpellSchool,
  			creditGUID, creditName, creditFlags, creditRaidFlags,
  			absorbSpellID, absorbSpellName, absorbSpellSchool,
  			amount = ...
  	end
  
  	if amount ~= nil and dstName and creditName then
  		heal.dstName = dstName
  		heal.dstGUID = dstGUID
  		heal.playerid = creditGUID
  		heal.playername = creditName
  		heal.spellid = absorbSpellID
  		heal.spellname = absorbSpellName
  		heal.amount = amount
  		heal.overhealing = 0
  		heal.critical = nil
  		heal.multistrike = nil
  		heal.absorbed = 0
  
  		Skada:FixPets(heal)
  		log_heal(Skada.current, heal)
  		log_heal(Skada.total, heal)
  	end
  end
  
  Skada:RegisterForCL(SpellAbsorbed, 'SPELL_ABSORBED', {})
  

  only downside: you can't track overhealing this way (I think)