227 - Absorbs Tracking
The Illuminated Healing absorb shield from a Holy Paladins mastery isn't included in the absorbs section.
Adding the spellId of Illuminated Healing (86273) to AbsorbSpellDuration will make full absorbs show, but partial absorbs are not being counted, at least for Illuminated Healing.
The SPELL_AURA_REMOVED event had 3 new parameters, the 13th one being the amount left on an absorb shield when it is removed (either by damage or right clicked off)
SPELL_AURA_APPLIED,0x0300000000DAAD7D,"Lynd",0x511,0x0300000000DAAD7D,"Lynd",0x511,17,"Power Word: Shield",0x2,BUFF,4040,0,0
SPELL_AURA_REMOVED,0x0300000000DAAD7D,"Lynd",0x511,0x0300000000DAAD7D,"Lynd",0x511,17,"Power Word: Shield",0x2,BUFF,4040,0,0
| Name | Description | Size | MD5 |
|---|---|---|---|
| WoWCombatLog.txt | Combatlog of a partial absorb | 12.3 KiB | 83ecf973acf1... |
missing partial absorb
- 8 comments
- 8 comments
Facts
- Last updated
- Mar 30, 2012
- Reported
- Oct 15, 2010
- Status
- New - Issue has not had initial review yet.
- Type
- Defect - A shortcoming, fault, or imperfection
- Priority
- Medium - Normal priority.
- Votes
- 5
- Component
- Recount
- Reply
- #8
Elsia Nov 08, 2010 at 04:01 UTC - 0 likesI need more information about val'anyr absorbs. Can I get relevant combat log lines? Thanks.
- Reply
- #7
onyxmaster Oct 25, 2010 at 17:23 UTC - 0 likesr1141 is better at tracking Illuminated Healing. Still not working for Val'Anyr bubbles though.
- Reply
- #6
onyxmaster Oct 22, 2010 at 08:05 UTC - 0 likesI'll try to provide logs today, but on our yesterday's 4-hour raid there was zero Val'anyr absorbs, although there were two healers with it. In fact, only like 1/3rd of PW:S and 1/10th of IH was tracked. RecountGuessedAbsorbs properly tracked those before. I'll do some testing with RGA and built-in absorb tracker tonight.
- Reply
- #5
ranky26 Oct 22, 2010 at 07:32 UTC - 0 likesAfter testing it would seem no partials are counted anywhere. I would test it on a paladin and illuminated healing but the issue seems to affect all absorb mechanics. I've attached a combatlog and screenshots to help with identifying the problem.
- Reply
- #4
ranky26 Oct 22, 2010 at 03:26 UTC - 0 likesI've installed the r1137 version and the tracking of Illuminated Healing for Effective Healing is working correctly.
The problem I had was with partial absorbs in the Absorb section only. Once the Illuminated Healing SpellID was added to Tracker module full absorbs were counted, partials were not. I'll test it again with the current version and upload a combatlog if the problem is still around.
- Reply
- #3
Cecile_Curse Oct 19, 2010 at 07:39 UTC - 0 likesI'm not really sure but what its seen to happen its that SPELL_AURA_REMOVED event tracked by Recount:SpellAuraRemoved its don't take into account the remaining amount.
function Recount:SpellAuraRemoved(timestamp, eventtype, srcGUID, srcName, srcFlags, dstGUID, dstName, dstFlags,spellId, spellName, spellSchool, auraType)
Shouldn't function prototype be like:
function Recount:SpellAuraRemoved(timestamp, eventtype, srcGUID, srcName, srcFlags, dstGUID, dstName, dstFlags,spellId, spellName, spellSchool, auraType, amount)
In fact I could see inside the function
local absorb = AllShields[dstName][spellId][srcName] - amount
but that amount isn't in the prototype.
May I right?
Thanks
- Reply
- #2
Elsia Oct 19, 2010 at 03:32 UTC - 0 likesI have done quite a bit of testing and cannot detect a problem. I have also compared the new absorb data with guessedabsorbs (a completely different mechanism) and there is no discrepancy I can see.
Can you guys try help isolate how exactly absorbs are missing/undercounted?
- Reply
- #1
calico0 Oct 15, 2010 at 20:15 UTC - 0 likesI'd be interested in seeing added the absorbs from bear druids Savage Defense (which absorbs one attack per buff then falls off), and the death knight's Blood Shield (which can partially absorb several attacks before failing). Both which only absorb physical damage but that shouldn't matter.