WowAce.com

RaidBuffStatus

401 - Patch for talents/options/scan buttons not showing when leaving combat

What steps will reproduce the problem?
1. Enable Hide Boss R Trash option.
2. Enter combat.
3. Leave combat.

What is the expected output? What do you see instead?
I expected the Talents, Options and Scan buttons on the dashboard to reappear when leaving combat, but they don't when the Hide Boss R Trash option is enabled.

What version of the product are you using?
5.9.1

Do you have an error log of what happened?
No errors are produced to log.

Please provide any additional information below.
This seems to be a logic error in the AddBuffButtons function due to a missing else case in the following if block.

if incombat then
    addon.talentsbutton:Hide()
    addon.optionsbutton:Hide()
    addon.scanbutton:Hide()
    currenty = currenty - 18
end

Adding an else case as shown in the following code appears to fix the error.

if incombat then
    addon.talentsbutton:Hide()
    addon.optionsbutton:Hide()
    addon.scanbutton:Hide()
    currenty = currenty - 18
else
    addon.talentsbutton:Show()
    addon.optionsbutton:Show()
    addon.scanbutton:Show()
end
User When Change
dragoonreas May 04, 2014 at 14:28 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

Facts

Reported
May 04, 2014
Status
New - Issue has not had initial review yet.
Type
Patch - Source code patch for review
Priority
Medium - Normal priority.
Votes
0

Reported by

Possible assignees