8 - Bug in line 476 with ChatFrameEditBox:Show(), should be ChatEdit_GetActiveWindow():Show()
What steps will reproduce the problem?
1. Enter binding mode
2. Hover over a button
3. Click Enter
What is the expected output? What do you see instead?
The expected output is to open the editbox in the last selected chatframe. But this library calls ChatFrameEditBox:Show(), which no longer exists. The error happens in LibKeyBound-1.0.lua line 476. Line 475-478 looks like this:
if openChatKey and key == openChatKey then
ChatFrameEditBox:Show()
return
end
when it should be changed to the following to work with the current version of WoW (4.3.2 as of writing this):
if openChatKey and key == openChatKey then
local f = ChatEdit_GetActiveWindow()
if (f) then
f:Show()
return
end
end
What version of the product are you using?
The latest. Labeled as 1.0 revision 99 on the site, but as 98 in the file itself.
Do you have an error log of what happened?
Just a nil error in the line described, 476.
Please provide any additional information below.
Updated the ticket with new code that I've tested to function as intended.
| User | When | Change |
|---|---|---|
| Goldpaw | Feb 08, 2012 at 07:10 UTC | Changed description:3. Click Enter What is the expected output? What do you see instead? - The expected output is to open the editbox in the last selected chatframe. But this library calls ChatFrameEditBox:Show(), which no longer exists. The error happens in LibKeyBound-1.0.lua, line 476 which looks look this: + The expected output is to open the editbox in the last selected chatframe. But this library calls ChatFrameEditBox:Show(), which no longer exists. The error happens in LibKeyBound-1.0.lua, line 476. Line 475-478 looks like this: + if openChatKey and key == openChatKey then - ChatFrameEditBox:Show() + ChatFrameEditBox:Show() + return + end when it should be changed to the following to work with the current version of WoW (4.3.2 as of writing this): + if openChatKey and key == openChatKey then - ChatEdit_GetActiveWindow():Show() + local f = ChatEdit_GetActiveWindow() + if (f) then + f:Show() + return + end + end What version of the product are you using? The latest. Labeled as 1.0 revision 99 on the site, but as 98 in the file itself. ---------------------------------------- Just a nil error in the line described, 476. Please provide any additional information below. + Updated the ticket with new code that I've tested to function as intended. |
| Goldpaw | Feb 08, 2012 at 06:51 UTC | Create |
