WowAce

Hello,

I have several issues with the latest version of this addon:

1) The color of the players icon is alway the default one (grey)

2) The players tooltip gives the default level (0) and default class name (Unknown)

I corrected it this way:

1) add this function at the end of the "GuildNotes.lua" file:

 2) Just after line 174, insert this line of code:

 This will correct the issues.

Kind regards,

Kouro

I also have the color issue...

inside "GuildNotes.lua"

function strsplitHN(delimiter, text)
  if type(delimiter) == "string" and type(text) == "string" then
   local list = {}
   local pos = 1
   if strfind("", delimiter, 1) then -- this would result in endless loops
  error("delimiter matches empty string!")
   end
   while 1 do
  local first, last = strfind(text, delimiter, pos)
  if first then -- found?
    tinsert(list, strsub(text, pos, first-1))
    pos = last+1
  else
    tinsert(list, strsub(text, pos))
    break
  end
   end
   return list
  end
end

where did you add this function

There are several bugs that come with this addon as of 5.4.7.

The addon will lay out a spot for your own caracter (very annoying)

When in a group with a guildy, the addon will still add a spot for him (and since the addon is less precise than the game in terms of speed of placement, you end up having two spots in different locations).

Characters' names now have a "-REALM_NAME" appended to them on the player labels on the map (useless).

I corrected these various points by edditing the .lua file, but I doubt my corrections are the most efficient ones... but they seam to be working so far...

I added this function :

function strsplitHN(delimiter, text)
  if type(delimiter) == "string" and type(text) == "string" then
   local list = {}
   local pos = 1
   if strfind("", delimiter, 1) then -- this would result in endless loops
  error("delimiter matches empty string!")
   end
   while 1 do
  local first, last = strfind(text, delimiter, pos)
  if first then -- found?
    tinsert(list, strsub(text, pos, first-1))
    pos = last+1
  else
    tinsert(list, strsub(text, pos))
    break
  end
   end
   return list
  end
end

I updated this function :

function GuildHandler:OnEnter(mapFile, coord)
 local tooltip = self:GetParent() == WorldMapButton and WorldMapTooltip or GameTooltip
 if ( self:GetCenter() > UIParent:GetCenter() ) then -- compare X coordinate
  tooltip:SetOwner(self, "ANCHOR_LEFT")
 else
  tooltip:SetOwner(self, "ANCHOR_RIGHT")
 end
 local player = findPlayer(mapFile, coord)
 if not player then return end
 local name = player.name
 local playerMinimalName = strsplitHN("-",name)[1]
 local playerServerName = strsplitHN("-",name)[2]
 local realmName = string.gsub(GetRealmName()," ","");
 if realmName == playerServerName then
  tooltip:AddLine("|cffe0e0e0" .. playerMinimalName .. "|r")
 else
  tooltip:AddLine("|cffe0e0e0" .. name .. "|r")
 end
 tooltip:AddLine(fmt("L%d - |cff%02x%02x%02x%s|r", playerLevel[name] or 0, player.icon.r * 255, player.icon.g * 255, player.icon.b * 255, playerClassLocalized[name] or UNKNOWN))
 tooltip:Show()
end

and this one :

function Guild:UpdateMember(event, sender, x, y, zone)
 local myPlayerName = UnitName("player");
 local realmName = string.gsub(GetRealmName()," ","");
 if sender ~= myPlayerName.."-"..realmName then
   if event == "Clear" then
    recycle(database[sender])
    database[sender] = nil
   elseif event == "Position" then
    local senderName = strsplitHN("-",sender)[1]
    if UnitInParty(senderName) == nil then
     database[sender].coord = HandyNotes:getCoord(x,y)
     database[sender].zone = zone
    else
     recycle(database[sender])
     database[sender] = nil
    end
   end
   self:SendMessage("HandyNotes_NotifyUpdate", "Guild")
 end
end

In case it helps anyone...