6 - Small correction of GuildNotes.lua to not show own location

What steps will reproduce the problem?
1. Simply log in on a character with the addon enabled

What is the expected output? What do you see instead?
I expect to see guild mates location on the world map thanks to a spot for each of them
I expect NOT to see my own thanks to those spots.
I end up seeing my guild mates properly, but also myself. There is a spot on top of my Arrow, or trying to follow my Arrow.

What version of the product are you using?

Please provide any additional information below.
I corrected this by adding an if loop in GuildNotes.lua to check wether or not the character for whom we are adding a spot is us or not.
The only affected function is Guild:UpdateMember starting at line 196.
This is what I've changed it to :

function Guild:UpdateMember(event, sender, x, y, zone)
    local myPlayerName = UnitName("player");
    local realmName = string.gsub(GetRealmName()," ","");
    if sender ~= myPlayerName.."-"..realmName then
        if event == "Clear" then
            database[sender] = nil
        elseif event == "Position" then
            database[sender].coord = HandyNotes:getCoord(x,y)
            database[sender].zone = zone
        self:SendMessage("HandyNotes_NotifyUpdate", "Guild")

There might be a better way to do it, but this does the trick all right so far.


User When Change
Nevcairiel Oct 17, 2014 at 22:14 UTC Changed status from New to Fixed
Kouro Feb 27, 2014 at 09:56 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 1 comment
  • Avatar of Nevcairiel Nevcairiel Oct 17, 2014 at 22:14 UTC - 0 likes

    This should be resolved differently.

  • 1 comment


Last updated
Oct 17, 2014
Feb 27, 2014
Fixed - Developer made requested changes. QA should verify.
Enhancement - A change which is intended to better the project in some way
Medium - Normal priority.

Reported by

Possible assignees