1 - Feature requests

I realize you don't consider this feature complete yet and probably had intended to do some of this stuff already, but I figured I'd put together a rather comprehensive list of what I'd like to see. Yes, this isn't my addon, so I have no expectations that you'll do any of this.

Feature requests:

Iterate over BNGetNumFriendToons() with BNGetFriendToonInfo() to get information about additional characters/game instances. - Done.
Alt+click to invite. - Done.
Shift+click to send a Who request. - Only information this shows that the main display doesn't is race and guild. Plus it's on a five-second throttle per request.
Ctrl+click to set a note (check CanEditPublicNote() for guild members). - Done.
Ctrl+right-click to set an officer note if CanEditOfficerNote(). - Done.
Clicking the broker opens the friends frame, so perhaps shift-clicking could be used to open the guild roster? - Already done via Alt-click
Allow the guild message of the day to be edited when clicked if CanEditMOTD(). - Done.
Add player's broadcast to the bottom of the friends list and allow clicking to edit, similar to the GMotD.
Color levels using GetQuestDifficultyColor() instead of basing it off of max level. This will make it easier to see who else is on that is within your level range. - Done. This is, after all, pretty much the standard.
Color realm names with faction color. - Not a fan, personally. It just looked BAD in SocialState, and I opted instead to add the faction emblem next to the player name.
Color zone names: Alliance, Horde, Contested, Sanctuary, Combat, etc.. - Done.
Color guild ranks with a gradient based on their index. - Done.
Consider giving notes their own columns to allow for more people to fit on the tooltip. Screen width is more abundant in comparison to height. - Done.
Add a class column populated by class icons for another method of sorting. - Done.
Add an option to reformat the string used for the broker's text. RealID Toons does something similar. I'd prefer to add the friends and Real ID counts together (ignoring duplicates and those who aren't in-game), as well as use different colors to match the rest of the brokers in my UI. In the meantime, I've changed my local copy as follows:

function DataObject:UpdateDisplay()
	local output = ("%d |cFF3E819B%s|r"):format(OnlineFriendsCount + OnlineBattleNetCount, _G.FRIENDS)

	if _G.IsInGuild() then
		output = ("%s %d |cFF3E819B%s|r"):format(output, OnlineGuildMembersCount, _G.GUILD)
	end

	self.text = output
end

User	When	Change
Talyrius	Sep 21, 2014 at 13:23 UTC	Changed description type from BBCode to WikiCreole Changed description: I realize you don't consider this feature complete yet and probably had intended to do some of this stuff already, but I figured I'd put together a rather comprehensive list of what I'd like to see. Yes, this isn't my addon, so I have no expectations that you'll do any of this. - [B]Feature requests:[/B] + Feature requests: - [LIST][][COLOR="green"]Iterate over BNGetNumFriendToons() with BNGetFriendToonInfo() to get information about additional characters/game instances.[/COLOR] - Done. + <<color green>>Iterate over BNGetNumFriendToons() with BNGetFriendToonInfo() to get information about additional characters/game instances.<</color>> - Done. - [][COLOR="green"]Alt+click to invite.[/COLOR] - Done. + <<color green>>Alt+click to invite.<</color>> - Done. - [][COLOR="red"]Shift+click to send a Who request.[/COLOR] - Only information this shows that the main display doesn't is race and guild. Plus it's on a five-second throttle per request. + <<color red>>Shift+click to send a Who request.<</color>> - Only information this shows that the main display doesn't is race and guild. Plus it's on a five-second throttle per request. - [][COLOR="green"]Ctrl+click to set a note (check CanEditPublicNote() for guild members).[/COLOR] - Done. + <<color green>>Ctrl+click to set a note (check CanEditPublicNote() for guild members).<</color>> - Done. - [][COLOR="green"]Ctrl+right-click to set an officer note if CanEditOfficerNote().[/COLOR] - Done. + <<color green>>Ctrl+right-click to set an officer note if CanEditOfficerNote().<</color>> - Done. - [][COLOR="green"]Clicking the broker opens the friends frame, so perhaps shift-clicking could be used to open the guild roster?[/COLOR] - Already done via Alt-click + <<color green>>Clicking the broker opens the friends frame, so perhaps shift-clicking could be used to open the guild roster?<</color>> - Already done via Alt-click - [][COLOR="green"]Allow the guild message of the day to be edited when clicked if CanEditMOTD().[/COLOR] - Done, though I'm awaiting confirmation from someone else since I'm not an officer in any guild, so I can't test. + <<color green>>Allow the guild message of the day to be edited when clicked if CanEditMOTD().<</color>> - Done. - []Add player's broadcast to the bottom of the friends list and allow clicking to edit, similar to the GMotD. + Add player's broadcast to the bottom of the friends list and allow clicking to edit, similar to the GMotD. - [][COLOR="green"]Color levels using GetQuestDifficultyColor() instead of basing it off of max level. This will make it easier to see who else is on that is within your level range.[/COLOR] - Done. This is, after all, pretty much the standard. + <<color green>>Color levels using GetQuestDifficultyColor() instead of basing it off of max level. This will make it easier to see who else is on that is within your level range.<</color>> - Done. This is, after all, pretty much the standard. - [][COLOR="red"]Color realm names with faction color.[/COLOR] - Not a fan, personally. It just looked BAD in SocialState, and I opted instead to add the faction emblem next to the player name. + <<color red>>Color realm names with faction color.<</color>> - Not a fan, personally. It just looked BAD in SocialState, and I opted instead to add the faction emblem next to the player name. - [][COLOR="green"]Color zone names: Alliance, Horde, Contested, Sanctuary, Combat, etc..[/COLOR] - Done. + <<color green>>Color zone names: Alliance, Horde, Contested, Sanctuary, Combat, etc..<</color>> - Done. - [][COLOR="green"]Color guild ranks with a gradient based on their index.[/COLOR] - Done. + <<color green>>Color guild ranks with a gradient based on their index.<</color>> - Done. - [][COLOR="green"]Consider giving notes their own columns to allow for more people to fit on the tooltip. Screen width is more abundant in comparison to height.[/COLOR] - Done. + <<color green>>Consider giving notes their own columns to allow for more people to fit on the tooltip. Screen width is more abundant in comparison to height.<</color>> - Done. - [][COLOR="green"]Add a class column populated by class icons for another method of sorting.[/COLOR] - Done. + <<color green>>Add a class column populated by class icons for another method of sorting.<</color>> - Done. - []Add an option to reformat the string used for the broker's text. [URL="http://www.wowace.com/addons/realid-toons/"]RealID Toons[/URL] does something similar. I'd prefer to add the friends and Real ID counts together (ignoring duplicates and those who aren't in-game), as well as use different colors to match the rest of the brokers in my UI. In the meantime, I've changed my local copy as follows:[/LIST] - [code] + Add an option to reformat the string used for the broker's text. [[http://www.wowace.com/addons/realid-toons/\|RealID Toons]] does something similar. I'd prefer to add the friends and Real ID counts together (ignoring duplicates and those who aren't in-game), as well as use different colors to match the rest of the brokers in my UI. In the meantime, I've changed my local copy as follows: + <<code lua>> function DataObject:UpdateDisplay() local output = ("%d \|cFF3E819B%s\|r"):format(OnlineFriendsCount + OnlineBattleNetCount, _G.FRIENDS) ---------------------------------------- self.text = output end - [/code] + <</code>>
Torhal	Sep 21, 2014 at 01:46 UTC	Changed description: [][COLOR="green"]Ctrl+click to set a note (check CanEditPublicNote() for guild members).[/COLOR] - Done. [][COLOR="green"]Ctrl+right-click to set an officer note if CanEditOfficerNote().[/COLOR] - Done. [][COLOR="green"]Clicking the broker opens the friends frame, so perhaps shift-clicking could be used to open the guild roster?[/COLOR] - Already done via Alt-click - []Allow the guild message of the day to be edited when clicked if CanEditMOTD(). + [][COLOR="green"]Allow the guild message of the day to be edited when clicked if CanEditMOTD().[/COLOR] - Done, though I'm awaiting confirmation from someone else since I'm not an officer in any guild, so I can't test. []Add player's broadcast to the bottom of the friends list and allow clicking to edit, similar to the GMotD. [][COLOR="green"]Color levels using GetQuestDifficultyColor() instead of basing it off of max level. This will make it easier to see who else is on that is within your level range.[/COLOR] - Done. This is, after all, pretty much the standard. [][COLOR="red"]Color realm names with faction color.[/COLOR] - Not a fan, personally. It just looked BAD in SocialState, and I opted instead to add the faction emblem next to the player name.
Torhal	Sep 19, 2014 at 02:37 UTC	Changed description: [B]Feature requests:[/B] [LIST][][COLOR="green"]Iterate over BNGetNumFriendToons() with BNGetFriendToonInfo() to get information about additional characters/game instances.[/COLOR] - Done. [][COLOR="green"]Alt+click to invite.[/COLOR] - Done. - []Shift+click to send a Who request. + [][COLOR="red"]Shift+click to send a Who request.[/COLOR] - Only information this shows that the main display doesn't is race and guild. Plus it's on a five-second throttle per request. [][COLOR="green"]Ctrl+click to set a note (check CanEditPublicNote() for guild members).[/COLOR] - Done. [][COLOR="green"]Ctrl+right-click to set an officer note if CanEditOfficerNote().[/COLOR] - Done. [*][COLOR="green"]Clicking the broker opens the friends frame, so perhaps shift-clicking could be used to open the guild roster?[/COLOR] - Already done via Alt-click
Torhal	Sep 19, 2014 at 01:19 UTC	Changed description: [LIST][][COLOR="green"]Iterate over BNGetNumFriendToons() with BNGetFriendToonInfo() to get information about additional characters/game instances.[/COLOR] - Done. [][COLOR="green"]Alt+click to invite.[/COLOR] - Done. []Shift+click to send a Who request. - []Ctrl+click to set a note (check CanEditPublicNote() for guild members). + [][COLOR="green"]Ctrl+click to set a note (check CanEditPublicNote() for guild members).[/COLOR] - Done. - []Ctrl+right-click to set an officer note if CanEditOfficerNote(). + [][COLOR="green"]Ctrl+right-click to set an officer note if CanEditOfficerNote().[/COLOR] - Done. [][COLOR="green"]Clicking the broker opens the friends frame, so perhaps shift-clicking could be used to open the guild roster?[/COLOR] - Already done via Alt-click []Allow the guild message of the day to be edited when clicked if CanEditMOTD(). []Add player's broadcast to the bottom of the friends list and allow clicking to edit, similar to the GMotD.
Talyrius	Sep 17, 2014 at 05:49 UTC	Changed description: [][COLOR="green"]Color guild ranks with a gradient based on their index.[/COLOR] - Done. [][COLOR="green"]Consider giving notes their own columns to allow for more people to fit on the tooltip. Screen width is more abundant in comparison to height.[/COLOR] - Done. [][COLOR="green"]Add a class column populated by class icons for another method of sorting.[/COLOR] - Done. - []Add an option to reformat the string used for the broker's text. [URL="http://www.wowace.com/addons/realid-toons/"]RealID Toons[/URL] does something similar. I'd prefer to add the friends and Real ID counts together, as well as use different colors to match the rest of the brokers in my UI. In the meantime, I've changed my local copy as follows:[/LIST] + [*]Add an option to reformat the string used for the broker's text. [URL="http://www.wowace.com/addons/realid-toons/"]RealID Toons[/URL] does something similar. I'd prefer to add the friends and Real ID counts together (ignoring duplicates and those who aren't in-game), as well as use different colors to match the rest of the brokers in my UI. In the meantime, I've changed my local copy as follows:[/LIST] [code] function DataObject:UpdateDisplay() local output = ("%d \|cFF3E819B%s\|r"):format(OnlineFriendsCount + OnlineBattleNetCount, _G.FRIENDS)
Torhal	Sep 17, 2014 at 04:04 UTC	Changed description: I realize you don't consider this feature complete yet and probably had intended to do some of this stuff already, but I figured I'd put together a rather comprehensive list of what I'd like to see. Yes, this isn't my addon, so I have no expectations that you'll do any of this. [B]Feature requests:[/B] - [LIST][]Iterate over BNGetNumFriendToons() with BNGetFriendToonInfo() to get information about additional characters/game instances. + [LIST][][COLOR="green"]Iterate over BNGetNumFriendToons() with BNGetFriendToonInfo() to get information about additional characters/game instances.[/COLOR] - Done. [][COLOR="green"]Alt+click to invite.[/COLOR] - Done. []Shift+click to send a Who request. [*]Ctrl+click to set a note (check CanEditPublicNote() for guild members).
Torhal	Sep 16, 2014 at 09:13 UTC	Changed description: [][COLOR="green"]Color zone names: Alliance, Horde, Contested, Sanctuary, Combat, etc..[/COLOR] - Done. [][COLOR="green"]Color guild ranks with a gradient based on their index.[/COLOR] - Done. [][COLOR="green"]Consider giving notes their own columns to allow for more people to fit on the tooltip. Screen width is more abundant in comparison to height.[/COLOR] - Done. - []Add a class column populated by class icons for another method of sorting. + [][COLOR="green"]Add a class column populated by class icons for another method of sorting.[/COLOR] - Done. []Add an option to reformat the string used for the broker's text. [URL="http://www.wowace.com/addons/realid-toons/"]RealID Toons[/URL] does something similar. I'd prefer to add the friends and Real ID counts together, as well as use different colors to match the rest of the brokers in my UI. In the meantime, I've changed my local copy as follows:[/LIST] [code] function DataObject:UpdateDisplay()
Torhal	Sep 16, 2014 at 03:38 UTC	Changed description: [B]Feature requests:[/B] [LIST][]Iterate over BNGetNumFriendToons() with BNGetFriendToonInfo() to get information about additional characters/game instances. - []Alt+click to invite. + [][COLOR="green"]Alt+click to invite.[/COLOR] - Done. []Shift+click to send a Who request. []Ctrl+click to set a note (check CanEditPublicNote() for guild members). []Ctrl+right-click to set an officer note if CanEditOfficerNote().
Torhal	Sep 16, 2014 at 03:01 UTC	Changed description: []Allow the guild message of the day to be edited when clicked if CanEditMOTD(). []Add player's broadcast to the bottom of the friends list and allow clicking to edit, similar to the GMotD. [][COLOR="green"]Color levels using GetQuestDifficultyColor() instead of basing it off of max level. This will make it easier to see who else is on that is within your level range.[/COLOR] - Done. This is, after all, pretty much the standard. - []Color realm names with faction color. + [][COLOR="red"]Color realm names with faction color.[/COLOR] - Not a fan, personally. It just looked BAD in SocialState, and I opted instead to add the faction emblem next to the player name. [][COLOR="green"]Color zone names: Alliance, Horde, Contested, Sanctuary, Combat, etc..[/COLOR] - Done. [][COLOR="green"]Color guild ranks with a gradient based on their index.[/COLOR] - Done. [][COLOR="green"]Consider giving notes their own columns to allow for more people to fit on the tooltip. Screen width is more abundant in comparison to height.[/COLOR] - Done.
Torhal	Sep 16, 2014 at 00:19 UTC	Changed description: [][COLOR="green"]Clicking the broker opens the friends frame, so perhaps shift-clicking could be used to open the guild roster?[/COLOR] - Already done via Alt-click []Allow the guild message of the day to be edited when clicked if CanEditMOTD(). []Add player's broadcast to the bottom of the friends list and allow clicking to edit, similar to the GMotD. - []Color levels using GetQuestDifficultyColor() instead of basing it off of max level. This will make it easier to see who else is on that is within your level range. + [][COLOR="green"]Color levels using GetQuestDifficultyColor() instead of basing it off of max level. This will make it easier to see who else is on that is within your level range.[/COLOR] - Done. This is, after all, pretty much the standard. []Color realm names with faction color. [][COLOR="green"]Color zone names: Alliance, Horde, Contested, Sanctuary, Combat, etc..[/COLOR] - Done. [][COLOR="green"]Color guild ranks with a gradient based on their index.[/COLOR] - Done.
Torhal	Sep 15, 2014 at 03:10 UTC	Changed description: []Add player's broadcast to the bottom of the friends list and allow clicking to edit, similar to the GMotD. []Color levels using GetQuestDifficultyColor() instead of basing it off of max level. This will make it easier to see who else is on that is within your level range. []Color realm names with faction color. - [][COLOR="red"]Color zone names: Alliance, Horde, Contested, Sanctuary, Combat, etc..[/COLOR] - Would require storing information for every zone in the game. Deal-breaker. + [][COLOR="green"]Color zone names: Alliance, Horde, Contested, Sanctuary, Combat, etc..[/COLOR] - Done. [][COLOR="green"]Color guild ranks with a gradient based on their index.[/COLOR] - Done. [][COLOR="green"]Consider giving notes their own columns to allow for more people to fit on the tooltip. Screen width is more abundant in comparison to height.[/COLOR] - Done. []Add a class column populated by class icons for another method of sorting.
Torhal	Sep 14, 2014 at 13:52 UTC	Changed description: []Shift+click to send a Who request. []Ctrl+click to set a note (check CanEditPublicNote() for guild members). []Ctrl+right-click to set an officer note if CanEditOfficerNote(). - []Clicking the broker opens the friends frame, so perhaps shift-clicking could be used to open the guild roster? + [][COLOR="green"]Clicking the broker opens the friends frame, so perhaps shift-clicking could be used to open the guild roster?[/COLOR] - Already done via Alt-click []Allow the guild message of the day to be edited when clicked if CanEditMOTD(). []Add player's broadcast to the bottom of the friends list and allow clicking to edit, similar to the GMotD. []Color levels using GetQuestDifficultyColor() instead of basing it off of max level. This will make it easier to see who else is on that is within your level range. []Color realm names with faction color. - []Color zone names: Alliance, Horde, Contested, Sanctuary, Combat, etc.. + [][COLOR="red"]Color zone names: Alliance, Horde, Contested, Sanctuary, Combat, etc..[/COLOR] - Would require storing information for every zone in the game. Deal-breaker. - []Color guild ranks with a gradient based on their index. + [][COLOR="green"]Color guild ranks with a gradient based on their index.[/COLOR] - Done. - []Consider giving notes their own columns to allow for more people to fit on the tooltip. Screen width is more abundant in comparison to height. + [][COLOR="green"]Consider giving notes their own columns to allow for more people to fit on the tooltip. Screen width is more abundant in comparison to height.[/COLOR] - Done. []Add a class column populated by class icons for another method of sorting. [*]Add an option to reformat the string used for the broker's text. [URL="http://www.wowace.com/addons/realid-toons/"]RealID Toons[/URL] does something similar. I'd prefer to add the friends and Real ID counts together, as well as use different colors to match the rest of the brokers in my UI. In the meantime, I've changed my local copy as follows:[/LIST] [code]
Talyrius	Sep 11, 2014 at 01:59 UTC	Changed description: I realize you don't consider this feature complete yet and probably had intended to do some of this stuff already, but I figured I'd put together a rather comprehensive list of what I'd like to see. Yes, this isn't my addon, so I have no expectations that you'll do any of this. [B]Feature requests:[/B] - [LIST][]Iterate over BNGetFriendToonInfo() with BNGetNumFriendToons() to get information about additional characters/game instances. + [LIST][]Iterate over BNGetNumFriendToons() with BNGetFriendToonInfo() to get information about additional characters/game instances. []Alt+click to invite. []Shift+click to send a Who request. [*]Ctrl+click to set a note (check CanEditPublicNote() for guild members).
Talyrius	Sep 11, 2014 at 01:57 UTC	Changed description: I realize you don't consider this feature complete yet and probably had intended to do some of this stuff already, but I figured I'd put together a rather comprehensive list of what I'd like to see. Yes, this isn't my addon, so I have no expectations that you'll do any of this. [B]Feature requests:[/B] + [LIST][]Iterate over BNGetFriendToonInfo() with BNGetNumFriendToons() to get information about additional characters/game instances. - [LIST][]Alt+click to invite. + []Alt+click to invite. []Shift+click to send a Who request. []Ctrl+click to set a note (check CanEditPublicNote() for guild members). []Ctrl+right-click to set an officer note if CanEditOfficerNote().
Talyrius	Sep 11, 2014 at 01:32 UTC	Create

You must login to post a comment. Don't have an account? Register to get one!

21 comments
1
2
3
Next →

- Reply
- #21
Talyrius Sep 21, 2014 at 10:58 UTC - 0 likes
@Torhal: Go

It was counting multi-byte characters as more than a single character, causing the last few characters of the current GMotD to not fit within the editbox.
- Reply
- #20
Torhal Sep 21, 2014 at 10:29 UTC - 0 likes
@Talyrius: Go

Altering it in what way?
- Reply
- #19
Talyrius Sep 21, 2014 at 10:16 UTC - 0 likes
@Torhal: Go

Yes, it works now. However, it was altering my existing GMotD until I commented out the dialog's max_bytes property, so perhaps you should omit that.
- Reply
- #18
Torhal Sep 21, 2014 at 08:58 UTC - 0 likes
@Torhal: Go

I believe I have it this time.
- Reply
- #17
Torhal Sep 21, 2014 at 07:22 UTC - 0 likes
@Talyrius: Go

Meh. I'm unable to test this, so no idea. I lucked out with the Public and Officer notes. :D
- Reply
- #16
Talyrius Sep 21, 2014 at 06:48 UTC - 0 likes
Quote:
Allow the guild message of the day to be edited when clicked if CanEditMOTD(). - Done, though I'm awaiting confirmation from someone else since I'm not an officer in any guild, so I can't test.

It's not working and there aren't any errors to report.
- Reply
- #15
Torhal Sep 20, 2014 at 02:40 UTC - 0 likes
@Talyrius: Go

Magic!
- Reply
- #14
Talyrius Sep 20, 2014 at 02:02 UTC - 0 likes
@Torhal: Go

I just compared the return values from GetGuildRosterInfo() between my main character (guild leader) and an alt who has full permissions and they were identical. However, I now see the officer notes in Frenemy on my alt and I'm not able to recreate a situation in which they don't. Truly bizarre.
- Reply
- #13
Torhal Sep 19, 2014 at 23:43 UTC - 0 likes
@Talyrius: Go

No idea why you wouldn't be able to see the Officer Note on your alts...it should be set by GetGuildRosterInfo() when I'm creating the list entries.

I somehow completely missed adding the ability to set Guild Officer notes.

Fixed the error. I was assigning the toon name to the lookup table for the index (which would be Name-Realm) instead of the ambiguated toon name (which would be Name).
- Reply
- #12
Talyrius Sep 19, 2014 at 08:13 UTC - 0 likes
I can't see the officer notes on my alt characters. I can see them in the guild roster though.
Dump: value=CanViewOfficerNote() [1]=1
Quote:
Ctrl+right-click to set an officer note if CanEditOfficerNote(). - Done.

I continue to get the options menu instead.
Dump: value=CanEditOfficerNote() [1]=1
Quote:
Ctrl+click to set a note (check CanEditPublicNote() for guild members). - Done.

I get an error for guild members:
1x Frenemy\Frenemy-5.4.8.7.lua:633: Usage: SetGuildRosterSelection(index) [C]: in function `SetGuildRosterSelection' Frenemy\Frenemy-5.4.8.7.lua:633: in function `_OnMouseUp_func' ...ceXPBarNone\Libs\LibQTip-1.0\LibQTip-1.0-42.lua:1223: in function <...ceXPBarNone\Libs\LibQTip-1.0\LibQTip-1.0.lua:1222>
Last edited Sep 19, 2014 by Talyrius

21 comments
1
2
3
Next →

Facts

Last updated: Sep 21, 2014
Reported: Sep 11, 2014
Status: New - Issue has not had initial review yet.
Type: Enhancement - A change which is intended to better the project in some way
Priority: Medium - Normal priority.
Votes: 1

Reported by

Talyrius

Possible assignees

Torhal
- Manager
- Author