Chatter

307 - Chatter taints setfocus when right clicking target frame when a player is targeted

What steps will reproduce the problem?
1. Install Chatter.
2. Select the player.
3. Right click the target frame and select 'Set Focus'

What is the expected output? What do you see instead?
Focus should be set as the target but Chatter taints the action so it is aborted.

What version of the product are you using?
1.4.6

Do you have an error log of what happened?
Contents of taint.log:

9/21 00:17:10.982  Global variable UIDROPDOWNMENU_MENU_LEVEL tainted by Chatter - Interface\FrameXML\UIDropDownMenu.lua:782 ToggleDropDownMenu()
9/21 00:17:10.982      DropDownList1Button4:OnEnter()
9/21 00:17:10.982  Execution tainted by Chatter while reading UIDROPDOWNMENU_MENU_LEVEL - Interface\FrameXML\UIDropDownMenu.lua:706 UIDropDownMenu_GetSelectedID()
9/21 00:17:10.982      Interface\FrameXML\UIDropDownMenu.lua:436 UIDropDownMenu_AddButton()
9/21 00:17:10.982      Interface\FrameXML\UnitPopup.lua:711 UnitPopup_AddDropDownButton()
9/21 00:17:10.982      Interface\FrameXML\UnitPopup.lua:570
9/21 00:17:10.982      UnitPopup_ShowMenu()
9/21 00:17:10.982      Interface\FrameXML\TargetFrame.lua:887 initFunction()
9/21 00:17:10.982      Interface\FrameXML\UIDropDownMenu.lua:69 UIDropDownMenu_Initialize()
9/21 00:17:10.982      Interface\FrameXML\UIDropDownMenu.lua:910 ToggleDropDownMenu()
9/21 00:17:10.982      DropDownList1Button4:OnEnter()
9/21 00:17:10.982  Interface\FrameXML\UIDropDownMenu.lua:758 UIDropDownMenuButton_OnClick()
9/21 00:17:10.982  An action was blocked because of taint from Chatter - FocusUnit()
9/21 00:17:10.982      Interface\FrameXML\UnitPopup.lua:1879 func()
9/21 00:17:10.982      Interface\FrameXML\UIDropDownMenu.lua:760 UIDropDownMenuButton_OnClick()
9/21 00:17:10.982      DropDownList1Button3:OnClick()

Please provide any additional information below.
I was able to recreate this error with no other addons loaded besides Chatter. Only Chatter was active when I generated that taint.log.

User When Change
DienesToo Sep 21, 2015 at 04:27 UTC Changed name from Chatter taints setfocus when right clicking a player to Chatter taints setfocus when right clicking target frame when a player is targeted
DienesToo Sep 21, 2015 at 04:26 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 2 comments
  • Avatar of witchsong witchsong Aug 13, 2016 at 19:32 UTC - 0 likes

    This is caused by lines 252-255 in the alt linking module (altnames.lua):

    	tinsert(UnitPopupMenus["SELF"], 	#UnitPopupMenus["SELF"] - 1,	"SET_MAIN")
    	tinsert(UnitPopupMenus["PLAYER"], 	#UnitPopupMenus["PLAYER"] - 1,	"SET_MAIN")
    	tinsert(UnitPopupMenus["FRIEND"],	#UnitPopupMenus["FRIEND"] - 1,	"SET_MAIN")
    	tinsert(UnitPopupMenus["PARTY"], 	#UnitPopupMenus["PARTY"] - 1,	"SET_MAIN")
    
    Last edited Aug 13, 2016 by witchsong
  • Avatar of transitbus transitbus Jan 13, 2016 at 16:12 UTC - 0 likes

    Can confirm. With chatter installed and only chatter active taint still happens. Had to enable buggrabber to get the following:

    [ADDON_ACTION_FORBIDDEN] AddOn 'Chatter' tried to call the protected function 'FocusUnit()'.
    !BugGrabber\BugGrabber.lua:573: in function <!BugGrabber\BugGrabber.lua:573>
    [C]: in function `FocusUnit'
    FrameXML\UnitPopup.lua:1879: in function `func'
    FrameXML\UIDropDownMenu.lua:760: in function `UIDropDownMenuButton_OnClick'
    [string "*:OnClick"]:1: in function <[string "*:OnClick"]:1>
    
    Locals:
    nil
    
  • 2 comments

Facts

Last updated
Sep 21, 2015
Reported
Sep 21, 2015
Status
New - Issue has not had initial review yet.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Medium - Normal priority.
Votes
0

Reported by

Possible assignees