Bartender4

1229 - Key bindings Legion Beta corruption (see image)

What steps will reproduce the problem? 1. In Legion beta run bartender with other addons that add to the key bindings interface frame 2. open key bindings 3. See attached image

What version of the product are you using? 4.6.14-9-ge550326

Do you have an error log of what happened? no error ouput - see image

Please provide any additional information below.

The below image shows what happens in beta with bartender and any other addon that adds to the key bindings options frame

Now just one addon in adition to BT won't necessarily corrupt. For example running only Bagnon with BT does not cause issues but if I add more addons that add to the key binding frame then in greatly increases the chance bartender corrupts.

BT alone does not corrupt. Other addons without BT loaded do not corrupt, only if bartender and other addons are loaded

For example, I loaded bartender, bagnon and litemount and the corruption happened. If I removed bagnon, it did not corrupt. Likewise if I left bagnon and disabled litemount, same thing.

The factor that causes the issue as seen in the image is bartender and how it loads key binding options but more importantly WHEN it loads. If I load two addons that have options in key bindings then go back and load bartender, I am fine. I think the issue is the order in which bartender loads and if it does before other addons, it corrupts the options frame in legion.

I also have been able to have it glitch with just two addons (using the addon lite mount and loading it after bartender as in loading bartender, reloading the ui, going back into the addon control panel and loading litemount). Something about the order in the category list button order causes bartender to mess up if other addons load there too.

keybind issue

User When Change
transitbus Jul 14, 2016 at 01:09 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • Avatar of Nevcairiel Nevcairiel Oct 15, 2016 at 09:48 UTC - 0 likes

    For the record it appears this is fixed in WoW 7.1

  • Avatar of Azurewren Azurewren Sep 10, 2016 at 15:04 UTC - 0 likes

    Can Bartenders Bindings.xml update to fix this please?

  • Avatar of Istaro Istaro Aug 14, 2016 at 05:31 UTC - 0 likes

    Thanks a ton transitbus! I was getting this with both Bartender4 and MoveAnything; I fixed the former by taking your suggestion of changing each

    category="Bartender4 "

    in Bindings.xml to

    category="BINDING_HEADER_Bartender4"

    and used your observations to figure out how to fix MoveAnything too (which has the name attributes in Bindings.xml set directly to the desired user-facing strings, which contain spaces, rather than to identifiers with the corresponding globals set in the .lua).

  • Avatar of Nevcairiel Nevcairiel Aug 08, 2016 at 05:39 UTC - 0 likes

    Bindings.xml is automatically loaded by Blizzard, you can't control when or how its loaded, unfortunately. As soon as its present, WoW loads it when the addon loads.

  • Avatar of transitbus transitbus Aug 07, 2016 at 21:09 UTC - 0 likes

    It's a load order thing with blizzard I think. If you see the corrupted key bindings category it pulls in, it either random shit or globla strings for non related stuff (I got globals for NPCs like wtf). Something on their end but it is like a table, index, or something stupid.

    Reloading will fix it but it is something on the initial player log in that screws it up. Maybe if you could wait to load the bindings.xml after PLAYER_ENTERING_WORLD this would solve it but I have no clue.

    As I said, sorry to waste your time, I know I am not considered knowledgeable on addons or anything for that matter but I try my best to take the effort to find out what is causing an error before I just report it.

  • Avatar of Nevcairiel Nevcairiel Aug 07, 2016 at 20:48 UTC - 0 likes

    So I installed three addons: Bartender4, Bagnon (since you named it as having "proper" bindings), and Skada, which also seems to have simple and properly setup bindings.xml (which really isn't that hard)

    I used your Bindings.xml for Bartender4 and logged in. Did a Reload UI once for good measure, since that often helps to cause the issue, and the corruption is there.

    I just don't see a way that actually fixes it. All attempts "fix" it for one try and then break again.

    Blizzard needs to correct the bug in the game, and thats all thats to it.

  • Avatar of transitbus transitbus Aug 07, 2016 at 20:46 UTC - 0 likes

    Ok I see what you mean now. It is for sure broken. I concede (was able to finally log in and have it stall out half way through reading the list of bindings for bartender.

    Sorry to waste your time.

  • Avatar of Nevcairiel Nevcairiel Aug 07, 2016 at 20:39 UTC - 0 likes

    Bartender4 running as the only addon always works fine for me anyway, its only in combination with other addons that it ever breaks. None of my other addons use a custom category though, only category="ADDONS" or no category at all (ie. Other)

  • Avatar of transitbus transitbus Aug 07, 2016 at 20:34 UTC - 0 likes

    Retract my previous statement about using global strings in concatenation of binding strings. I made them work fine, just need to load properly.

  • Avatar of transitbus transitbus Aug 07, 2016 at 20:17 UTC - 0 likes

    Try this

    https://www.dropbox.com/s/ltiwmteta6vc5wv/Bindings.xml?dl=0

    It's simply your bindings.xml with category="Bartender4 " replaced with category="BINDING_HEADER_Bartender4" (no spaces in the quotes!)

    Load that with no other addons loaded and if it breaks still I will concede. It is working for me 100% of the time until I load another addon that isn't playing correct with how to do bindings.xml NOW post 7.0. As soon as you load one of those addons not done correct it is going to blow up but that is from the other addons not bartender.

    So the bindings.xml entries look like this now

    	<Binding name="CLICK BT4Button1:LeftButton" header="BT4BLANK1" category="BINDING_HEADER_Bartender4"/>
    	<Binding name="CLICK BT4Button2:LeftButton" category="BINDING_HEADER_Bartender4"/>
    
    Last edited Aug 07, 2016 by transitbus

Facts

Last updated
Sep 08, 2016
Reported
Jul 14, 2016
Status
New - Issue has not had initial review yet.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Medium - Normal priority.
Votes
3

Reported by

Possible assignees