WowAce.com

Baggins

106 - Reagent Bank Patch

Updates Baggins to support the new Reagent Bank added in 6.0.2.

Once patched, baggins will treat the reagent bank as it does with all other bank bags. There is a new special bank empty slot, prefixed with "r" which counts the reagent bank slots. When depositing items, baggins will automatically place crafting reagents into the reagent bank (until it's full). This effectively makes the reagent bank fully automatic. This automatic handling of reagents can be toggled on/off from the options.

In addition, a new "Bank Control Frame" has been added which works like the money frame. This attaches it's self to "Bank Other" by default, but can be moved like the money frame. This frame shows buttons to: buy missing bank slots, buy the reagent bank, and deposit all reagents into the reagent bank. These are all blizzard functions, and were previously unavailable if the default bank UI was hidden. With this addition, the default bank is only required to place bags.

The only thing missing is compression within the reagent bank. I'm still looking into this, but the patch greatly improves the feature even without sorting.

The patch comes in 2 files, as both Baggins and LibBagUtils-1.0 required updates. Patch can be applied using:
patch -p1 < baggins_reagent_bank.patch
patch -p1 < lbu_reagent_bank.patch

If patching LBU outside of baggins, use -p3:
patch -p3 < lbu_reagent_bank.patch

Name Description Size MD5
baggins_reagent_bank.patch &emdash; 28.4 KiB a14628787d16...
lbu_reagent_bank.patch &emdash; 6.9 KiB e6104bb13861...
baggins_reagent_bank_2.patch Apply last, fixes item button ... 4.5 KiB bd8735c8400a...
User When Change
mikk Oct 22, 2014 at 01:06 UTC Changed status from Fixed to Started
mikk Oct 22, 2014 at 01:06 UTC Changed status from New to Fixed
atholbro Oct 18, 2014 at 02:56 UTC

Added attachment baggins_reagent_bank_2.patch
atholbro Oct 18, 2014 at 02:56 UTC

Deleted attachment test.patch: wrong eol, and has debug message
atholbro Oct 18, 2014 at 02:43 UTC

Added attachment test.patch
atholbro Oct 17, 2014 at 19:54 UTC

Added attachment lbu_reagent_bank.patch
atholbro Oct 17, 2014 at 19:54 UTC

Added attachment baggins_reagent_bank.patch
atholbro Oct 17, 2014 at 19:54 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 7 comments
  • Avatar of mikk mikk Nov 08, 2014 at 03:01 UTC - 0 likes

    I'm also wondering if there should/would be any relevant changes for the Compress (ring-to-rings symbol) button...

  • Avatar of atholbro atholbro Oct 25, 2014 at 01:34 UTC - 0 likes

    Thanks.

    My LBU update was mostly just to get Baggins working, so it does need further work.

  • Avatar of mikk mikk Oct 22, 2014 at 01:05 UTC - 0 likes

    Nice work. I've tested it and it Works For Me(tm) so I'll push this as release.

    I'm a bit unsure about LBU though... it feels like LBU should maybe use the reagentbank more automatically without the user having to worry about it - like how it automatically puts things in regular reagent bags when they are available.

    As for tagging.. nah I haven't. I just edit the file to be Release.

    Last edited Oct 22, 2014 by mikk
  • Avatar of atholbro atholbro Oct 19, 2014 at 19:41 UTC - 0 likes

    I put the changes up (just assumed repo would be private). How do you mark as beta/release as it looks like you haven't been tagging (mostly curious, it can stay alpha for a while)?

    Last edited Oct 19, 2014 by atholbro
  • Avatar of mikk mikk Oct 18, 2014 at 20:47 UTC - 0 likes

    Unless you have an aversion to SVN, you're welcome to just commit things like this to the repo you know - it's open access :)

  • Avatar of atholbro atholbro Oct 18, 2014 at 02:57 UTC - 0 likes

    Fixed the issue, apply baggins_reagent_bank_2 last.

  • Avatar of atholbro atholbro Oct 18, 2014 at 02:33 UTC - 0 likes

    The above patch is broken, causes taint on item button. I have a fix, testing it now.

  • 7 comments

Facts

Last updated
Oct 22, 2014
Reported
Oct 17, 2014
Status
Started - Work on this issue has begun.
Type
Patch - Source code patch for review
Priority
Medium - Normal priority.
Votes
0

Reported by

Possible assignees