4 - Alternative to :EnableKeyboard()
When you use :EnableKeyboard(), you kill my key bindings. I like to press "B" to open my bags while the quest completed dialog is open.
I have hacked out an alternative.
Proposed change attached.
| User | When | Change |
|---|---|---|
| egingell | Jan 31, 2011 at 00:05 UTC | Changed status from Waiting to Replied |
| yssaril | Jan 29, 2011 at 15:45 UTC | Changed status from Accepted to Waiting |
| yssaril | Jan 29, 2011 at 02:48 UTC | Added attachment Core.lua |
| yssaril | Jan 29, 2011 at 02:47 UTC | Deleted attachment Core.lua: bahh forgot to unregister for keyboard input |
| yssaril | Jan 29, 2011 at 02:45 UTC | Added attachment Core.lua |
| yssaril | Jan 29, 2011 at 02:45 UTC | Deleted attachment Core.lua: error in file |
| yssaril | Jan 29, 2011 at 02:43 UTC | Added attachment Core.lua |
| yssaril | Jan 28, 2011 at 23:20 UTC | Changed status from New to Accepted |
| egingell | Jan 28, 2011 at 23:16 UTC | Added attachment Core.lua |
| egingell | Jan 28, 2011 at 23:15 UTC | Create |
- 6 comments
- 6 comments
Facts
- Last updated
- Jan 31, 2011
- Reported
- Jan 28, 2011
- Status
- Replied - Someone has replied after waiting for more information.
- Type
- Enhancement - A change which is intended to better the project in some way
- Priority
- Medium - Normal priority.
- Votes
- 0
- Reply
- #6
egingell Jan 31, 2011 at 03:51 UTC - 0 likesPressing any modifier changes the text to "Complete Quest & Equip Item" regardless of whether one is chosen or not and stays like that unless I cancel and talk to the NPC again.
No Lua error.
It's the same quest as I mentioned in ticket #5.
Edit: And when I click one of the rewards, the text goes back to "Complete & Get Highest Value".
- Reply
- #5
egingell Jan 31, 2011 at 00:05 UTC - 0 likesNo errors, but I haven't had a quest where multiple items were obtainable and equipable.
- Reply
- #4
yssaril Jan 29, 2011 at 15:45 UTC - 0 likescheck out the alpha version btw (it fixes some drycoding errors in the core lua attached here)
- Reply
- #3
egingell Jan 29, 2011 at 09:47 UTC - 0 likesMODIFIER_STATE_CHANGE is superior than trapping key strokes and, possibly, better than OnUpdate. Will try later.
- Reply
- #2
yssaril Jan 29, 2011 at 02:47 UTC - 0 likescan you try the new Core.lua file i attached? (cant test from work) is uses the MODIFIER_STATE_CHANGED event to track state changes hopefully)
- Reply
- #1
yssaril Jan 28, 2011 at 23:20 UTC - 0 likeshmm will look into it (patch looks sound though i do want to try to avoid OnUpdate) will have a look at it tonight