Archy - Archaeology Assistant

551 - Add LDB launcher with different functionality

Quote:

charleslaine: Would you please consider changing one line of code in this addon. It's in Tooltip.lua, line number 26...

type = "data source",

Could you change it to "launcher" instead?

local LDB_object = LibStub("LibDataBroker-1.1"):NewDataObject("Archy", { type = "launcher", icon = Interface\Icons\trade_archaeology, iconCoords = { 0.075, 0.925, 0.075, 0.925 }, text = "Archy", })

Every time a new version of Archy is released, I go and change my local installed source. I see no discernable negative side effect from this change. But the BENEFIT is, Archy is now compatible with OPie. It's icon can be placed onto an OPie ring, hidden and tucked away until I need to toggle Archy on or off.

Quote:

Me: The problem with that is there is a distinct difference between a data source and a launcher - launchers are meant mainly for "launching" something else, and aren't set up to handle the same things per the LDB spec (https://github.com/tekkub/libdatabroker-1-1/wiki/Data-Specifications),

Additionally, changing from data source to launcher will also cause some (if not all) displays to register it as a completely new plugin, which will move it to wherever the default "new plugin" spot is for the display. I could look into adding a launcher in addition to the data source; perhaps something without the tooltip, that performs distinctly different actions from the existing data source. Make a ticket, so I'll remember to get to it after (or perhaps during!) I finish what I'm working on now.

Quote:

charleslaine: Thanks. I'll make a ticket, etc. I've long been modifying archy by adding an additional command that I can then macro. The command... /archy toggle. It merely executed the same code that is executed when the minimap button is clicked. But's always been a hassle to have to go in and make this manual change each and every time a new version of the addon is released. And on top of that, one of your recent releases appeared to be a drastic rewrite/refactor of the code. I didn't even know where to look to continue to make that same manual edit.

I know that archy has the command... /archy stealth, but it just hides the panels. The "widget" for doing surveys, crating an artifact and soforth is still displayed when archy is in stealth mode. I needed a way to completely hide everything. But apart from the minimap button, there is no way to do this. That is what led me down the path of mucking around with the LDB code. I found that by changing it to launcher, it did what I needed. I could add it to OPie, and when selected, it would 100% show or hdie all of the Archy frames.

But as you say, it sounds like there are negative side effects.

The reasoning/justification for all of this... I don't like minimap buttons at all. They clutter up the screen and I hide them all. In general, I like to tuck away as much stuff as possible. OPie is a great little addon for this. I click a button and bam, a ring appears with all the addon icons... dominos, raven, atlas, omen, quartz, dbm, msbt etc etc

User When Change
Torhal Mar 06, 2015 at 07:29 UTC Changed description:
  Additionally, changing from data source to launcher will also cause some (if not all) displays to register it as a completely new plugin, which will move it to wherever the default "new plugin" spot is for the display. I could look into adding a launcher in addition to the data source; perhaps something without the tooltip, that performs distinctly different actions from the existing data source. Make a ticket, so I'll remember to get to it after (or perhaps during!) I finish what I'm working on now.
  <</quote>>
+
+ <<quote>>
+ charleslaine:
+ Thanks.  I'll make a ticket, etc.  I've long been modifying archy by adding an additional command that I can then macro.  The command... /archy toggle.  It merely executed the same code that is executed when the minimap button is clicked.   But's always been a hassle to have to go in and make this manual change each and every time a new version of the addon is released.  And on top of that, one of your recent releases appeared to be a drastic rewrite/refactor of the code.  I didn't even know where to look to continue to make that same manual edit.
+
+ I know that archy has the command... /archy stealth, but it just hides the panels.  The "widget" for doing surveys, crating an artifact and soforth is still displayed when archy is in stealth mode.  I needed a way to completely hide everything.   But apart from the minimap button, there is no way to do this.  That is what led me down the path of mucking around with the LDB code.  I found that by changing it to launcher, it did what I needed.  I could add it to OPie, and when selected, it would 100% show or hdie all of the Archy frames.
+
+ But as you say, it sounds like there are negative side effects.
+
+ The reasoning/justification for all of this... I don't like minimap buttons at all.  They clutter up the screen and I hide them all. In general, I like to tuck away as much stuff as possible.  OPie is a great little addon for this.  I click a button and bam, a ring appears with all the addon icons... dominos, raven, atlas, omen, quartz, dbm, msbt etc etc
+ <</quote>>
Torhal Mar 06, 2015 at 07:28 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

Facts

Last updated
Mar 06, 2015
Reported
Mar 06, 2015
Status
Accepted - Problem reproduced / Need acknowledged.
Type
Enhancement - A change which is intended to better the project in some way
Priority
Medium - Normal priority.
Votes
0

Reported by

Possible assignees