Ace3

393 - Margins between GUI elements

Actual blocks ("normal", "half", "double") are without margins and their content is does not look good next to each other.

I made modifications, "AceGUI" when:
- Width of the content is equal to "width_multiplier" so 170
- The offset is equal to 16 (varible leftMargin) and is set as the value of the SetPoint
- usedwidth = framewidth + usedwidth + leftMargin

I also made a few cosmetic repairs positional value in order to align elements uniform.

It would be possible to add these changes into the library?

I attach a modified library AceGUI. All changed / added parts are marked with commentary "-- MSA".

Thank you
Kaliel

Name Size MD5
AceGUI-3.0-modified.zip 55.5 KiB ceb869b71433...
AceGUI-3.0-modified.patch 9.9 KiB be00208f0475...
  • acegui-default.jpg
    AceGUI - default
  • acegui-modified.jpg
    AceGUI - modified
User When Change
Kaliel Jul 31, 2016 at 19:32 UTC

Added attachment AceGUI-3.0-modified.patch

Kaliel Jul 31, 2016 at 19:13 UTC

Added attachment AceGUI-3.0-modified.zip

Kaliel Jul 31, 2016 at 19:13 UTC

Deleted attachment AceGUI-3.0-modifed.zip: ...

Kaliel Jul 31, 2016 at 19:12 UTC

Added attachment acegui-modified.jpg

Kaliel Jul 31, 2016 at 19:11 UTC

Added attachment acegui-default.jpg

Kaliel Jul 31, 2016 at 19:10 UTC

Added attachment AceGUI-3.0-modifed.zip

Kaliel Jul 31, 2016 at 19:10 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 5 comments
  • Avatar of Kaliel Kaliel Jul 31, 2016 at 23:18 UTC - 0 likes

    Thank you for reply. It was not necessary immediately to report my project!?
    That's why I asked ... to put it right.

  • Avatar of Nevcairiel Nevcairiel Jul 31, 2016 at 19:49 UTC - 0 likes

    The options table will not get settings like margins, its meant to be generic and unaware of such UI fine-tuning.

    You should also be aware that we really do not like people shipping modified versions of the Ace3 libraries without changing the names of the libraries, because it would affect any and every addon using them when your addon is loaded. So please change that immediately.

    Last edited Jul 31, 2016 by Nevcairiel
  • Avatar of Kaliel Kaliel Jul 31, 2016 at 19:43 UTC - 0 likes

    It would be good add margin as a configuration value. For the entire configuration or for individual nodes.

    Example:

    ...
    args = {
    	general = {
    		name = "Options",
    		type = "group",
    		margin = 16,
    		args = {
    			sec1 = {
    				name = "Info",
    				type = "group",
    				inline = true,
    				...
    
  • Avatar of Kaliel Kaliel Jul 31, 2016 at 19:32 UTC - 0 likes

    SVN patch uploaded.

  • Avatar of Nevcairiel Nevcairiel Jul 31, 2016 at 19:11 UTC - 0 likes

    Please provide a patch/diff file so it can be reviewed properly. Full files are not all that helpful.

  • 5 comments

Facts

Last updated
Jul 31, 2016
Reported
Jul 31, 2016
Status
New - Issue has not had initial review yet.
Type
Enhancement - A change which is intended to better the project in some way
Priority
Medium - Normal priority.
Votes
0
Component
AceGUI-3.0

Reported by

Possible assignees