338 - Deprecated calls to SetScript() instead of HooKscript() on non secure frames

What steps will reproduce the problem?
1. Use :HookScript() on a non-secure frame

What is the expected output? What do you see instead?
The requested hook should be done using :HookScript() instead it's being made with :SetScript() on line 230

SetScript() should never be called on non-user frames...

In the source code, it's written in a comment above the offending SetSCript() call that HookScript() won't work if no script is currently set. This appears to be no longer true, so HookScript() should be used instead :-) This might prevent some tainting issues...

What version of the product are you using?

User When Change
Nevcairiel Oct 12, 2014 at 08:16 UTC Changed status from New to Fixed
Archarodim Apr 14, 2013 at 20:23 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 1 comment
  • Avatar of Nevcairiel Nevcairiel Apr 23, 2013 at 18:25 UTC - 0 likes

    SetScript is only used on insecure frames or on scripts which didn't exist before, i doubt it matters at all for taint related issues.

  • 1 comment


Last updated
Oct 12, 2014
Apr 14, 2013
Fixed - Developer made requested changes. QA should verify.
Defect - A shortcoming, fault, or imperfection
Medium - Normal priority.

Reported by

Possible assignees