Fix isInRaid, Add proper fallback to party chat, add Monk #11


  • Enhancment
  • Accepted
Open
Assigned to _ForgeUser1241155
  • _ForgeUser3563920 created this issue Dec 4, 2012

    I firstly fixed isInRaid() which should have been IsInRaid(), also you can not do > 0 on a boolean, so removed that.

    Secondly I made it so it checks if you are able to use RaidWarnings if not use Raid if not in Raid use Party, much more useful this way, might want to add some config for it though.

    Thirdly I added Monks, I'm not pro monk so this is very very preliminary but thought I'd try and start it for you as I love this addon and wanted to add back to it.

    Thanks for this add on and I hope this helps you and others.

  • _ForgeUser3563920 added the tags New Enhancment Dec 4, 2012
  • _ForgeUser3563920 added an attachment TankWarnings.fixed_monk.patch Dec 4, 2012

    TankWarnings.fixed_monk.patch

    <p>Patch against 1.32</p>

  • _ForgeUser1241155 posted a comment Dec 4, 2012

    Awesome, thank you very much for those changes, I'll update repo tomorrow during work and tag a release.

  • _ForgeUser1241155 removed a tag New Dec 4, 2012
  • _ForgeUser1241155 added a tag Accepted Dec 4, 2012
  • _ForgeUser3563920 posted a comment Dec 4, 2012

    excellent thanks for the very quick response time too, I'll keep playing with my monk to see if anything is missing in the meantime.

    so far the party fallback is really nice for 5 mans and scenarios when using things like avert harm where the healer really should know.

    I'll see if I can figure out how to add the /rw->/r->/p fallbacks as options, that way ppl can just enable the ones they want perhaps.

  • _ForgeUser3563920 posted a comment Dec 4, 2012

    Actually now that it's working again I see the spells for my druid aren't really that great so I'm going to update them as well, I'll send a new patch tomorrow.

    Going to test with my pally and dk as well.

    This is the Druid update this is using my build, I think Cenarion Ward might need to be added with a target but since i don't have it I'm not sure. This patch needs to be added after the first patch I added.

    My DK isn't 90 yet, so I'll wait on updating him, Just going to check my Pally next.

    I have a 90 warrior but I don't really play him as prot but I can check that as well if you'd like.


    Edited Dec 5, 2012
  • _ForgeUser3563920 posted a comment Dec 6, 2012

    Okay I just finished up paladins and warriors, I also renumbered everything to allow 5 resists per class and 10 CDs. I'll make a new full patch to send right away but just wanted to let you know. I should have my monk and dk to lvl 90 in the next week or 2 and i'll finish those up at that point.

  • _ForgeUser1241155 posted a comment Dec 6, 2012

    Just applied your patches and updated TOC, tagged a beta version and I'll wait for you changes when the monk/dk hit lvl 90. In the meanwhile, any error yell at me.

    Best regards.

  • _ForgeUser3563920 posted a comment Dec 6, 2012

    Damn this new patch is a full patch against 1.32 and I updated the toc to 5.1 as well in it ;)

    I haven't had time to make the fallback to raid and party an option yet going to work on that tonight for you.

    Here is the full patch this has everything from before, monk, druid, isInRaid fix and the fallbacks plus warrior and pally updates.


    Edited Dec 6, 2012
  • _ForgeUser1241155 posted a comment Dec 6, 2012

    No worries, I'll sort the patch stuff.

  • _ForgeUser3563920 posted a comment Dec 6, 2012

    excellent :D so excited to help out :D

  • _ForgeUser1241155 posted a comment Dec 7, 2012

    Ok, svn tree has all the changes, and tagged it 1.4, new minor version for the new expansion. Right now, I don't have WoW easily available to thoroughly test this changes, so I'll wait a bit and see if anyone complaints about anything before tagging it a release.

    Keep up the nice work, and thanks for the hard work you did.

  • _ForgeUser3563920 posted a comment Dec 7, 2012

    @rbarreiros: Go

    no problem at all and if I find more chances as my tanks hit 90 I'll be sure to let you know, and hopefully today I will work on make the announce channel thing into an option.

    I'll try and grab snv today so that i can test it and make all future patches against it and I'll open new tickets for them and let this one rest now ;)

  • _ForgeUser3563920 posted a comment Dec 7, 2012

    just to confirm SVN works perfectly, I just added a new ticket for the fallback options, also rewrote the if blocks to be a little cleaner.

    Thanks again for this wonderful plugin.

  • _ForgeUser3563920 posted a comment Dec 7, 2012

    Oh and don't forgot to update the front page here and on curses since it now supports brewmaster monks too. :P

  • _ForgeUser1241155 posted a comment Dec 25, 2012

    Got back home monday from a big gig and got Christmas in the middle, will update the page tomorrow/after tomorrow.

  • _ForgeUser3563920 posted a comment Dec 28, 2012

    yup no problem at all just wanted a place to remind ya. Take a look at my other patch too it adds a few more controls for this fallback.


To post a comment, please login or register a new account.