attempt to compare number with boolean #28


  • New
  • Defect
Open
Assigned to _ForgeUser44280
  • TheKiber created this issue Mar 23, 2015

    What steps will reproduce the problem?
    While doing doing various quest actions - for example:
    - using Beast Muisek Vessel http://www.wowhead.com/item=9618 for quest Testing the Vessel http://wowhead.com/quest=3123
    - accepting quest Return to Sage Palerunner http://wowhead.com/quest=25645.
    - collecting Thick Yeti Hide http://www.wowhead.com/item=8973 for quest The Mark of Quality http://www.wowhead.com/quest=25452

    What is the expected output? What do you see instead?
    Error

    What version of the product are you using?
    v14

    Do you have an error log of what happened?
    39x QuestHubber\QuestHubber-v14.lua:797: attempt to compare number with boolean
    QuestHubber\QuestHubber-v14.lua:797: in function `?'
    ...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0-6.lua:147: in function <...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:147>
    [string "safecall Dispatcher[1]"]:4: in function <[string "safecall Dispatcher[1]"]:4>
    [C]: ?
    [string "safecall Dispatcher[1]"]:13: in function `?'
    ...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0-6.lua:92: in function `Fire'
    Ace3\AceEvent-3.0\AceEvent-3.0-3.lua:120: in function <Ace3\AceEvent-3.0\AceEvent-3.0.lua:119>

    Locals:
    nil

    Please provide any additional information below.
    -

  • TheKiber added the tags New Defect Mar 23, 2015
  • _ForgeUser581183 posted a comment Apr 24, 2016

    The problem is that Blizzard changed GetQuestLogTitle(n): they removed the 3rd return value:

    questTitle, level, questTag, suggestedGroup, isHeader, isCollapsed, isComplete, isDaily, questID, startEvent = GetQuestLogTitle(questLogID);

    This means that all the code that tries to get the questID:

    local name, _, _, _, _, _, _, _, id = GetQuestLogTitle(i);
    

    will now be off-by-one; and the id will actually contain the startEvent flag (a Boolean value).

    The fix, in three places, is to change:

    From: local name, _, _, _, _, _, _, _, id = GetQuestLogTitle(i);
    To:   local name, _, _, _, _, _, _, id = GetQuestLogTitle(i);
    

    removing one of the variable placeholders.


To post a comment, please login or register a new account.