Error parsing UnitGUID #8


  • Defect
Open
  • RubioTwitch created this issue Mar 29, 2018

    There are three instances where the following code is used to parse the vNpcid from the npc_id field extracted from UnitGUID("npc"):

         local vNpcid = tonumber(npc_id, 16)

     

    However, this code is in error. The npc_id field in the UnitGUID is *NOT* represented in hexadecimal, it's in plain decimal.  The correct code should be:

         local vNpcid = tonumber(npc_id)

     

    This error causes duplicate entries in the db for folks who have been using the addon prior to when this methodology of grabbing the vNpcid went in.

    It also prevents the IgnoredVendors from being filtered out, as the vNpcid values are parsing incorrectly and will thus never match those table entries.

    Fixing this will make ignoring mammoth/yak mount vendors magically work again, resolving Issue #7.

     

     

  • RubioTwitch added a tag Defect Mar 29, 2018

To post a comment, please login or register a new account.