Bugs out when trying to link a top score to chat #15


  • Defect
  • Replied
Open
Assigned to polyhydride
  • _ForgeUser23487 created this issue Jun 30, 2011

    What steps will reproduce the problem?

    1. With the chat box active, mouse over the TopScoreFu feed to bring up the tooltip

    2. Click one of the spell headers with top score(s) showing (i.e. for a Huntard, "Multi-Shot")

    What is the expected output? What do you see instead?

    Expected: the normal and/or critical scores for that spell to be output to the chat box.

    Instead: an error is thrown and nothing further happens.

    What version of the product are you using?

    v1.0.11 and every release/alpha from the past year (since WoW 3.3.5).

    Do you have an error log of what happened?

    ["message"] = "FuBar_TopScoreFu-v1.0.11\\TopScoreFu.lua:772: attempt to index global 'ChatFrameEditBox' (a nil value)\n",
    			["type"] = "error",
    			["time"] = "2011/06/30 00:13:57",
    			["session"] = 3076,
    			["counter"] = 11,
    		}, -- [999]
    

    Please provide any additional information below.

    Fix to this problem (also seen in other mods last year) has been widely reported. Just change the ChatFrameEditBox text (in a few locations in the mod) to ChatFrame1EditBox. After doing that, no further errors linking top scores to chat.

    I submitted the fix to the GIT repo last year for the author(s) to add to the trunk, but it was not added for some reason. I guess when no one files a ticket, the tree falling in the forest is not heard. Or something.

  • _ForgeUser23487 added the tags New Defect Jun 30, 2011
  • polyhydride posted a comment Jul 4, 2011

    Hopefully fixed now. Sorry it took so long, I never saw any patch in git for this, so I'm not sure what wowace git is doing. Used my EditBox code from XPBarNone for the fix, so it should be good.

  • polyhydride removed a tag New Jul 4, 2011
  • polyhydride added a tag Waiting Jul 4, 2011
  • _ForgeUser23487 posted a comment Jul 5, 2011

    Yes, v1.0.11-1-g681d300 fixes the issue. No bugs and linking to chat works without issue.

    Yah, rather strange how the dev GIT repo works/worked here. The commit ended up in a branch off the master instead of directly on the master; I was unable to put it there. Due to the fact I'm not an author (or translator) of the project or something...it was later deleted.

    Your fix is more elegant, however; mine was just a sledgehammer search/replace of ChatFrameEditBox with ChatFrame1EditBox. So nothing lost other than the record of it.

    Finally, yes, its been requested in the past, but here's hoping this is ported to LDB/Ace3. No longer use it in my raid ACP mod sets due to it being close to the last Ace2 mod I have. With FuBar & Ace2 being long obsoleted, more and more other people are in the same situation.

    This has always been more reliable than similar proc recording mods. So hope to see it continue its reliability with modern frameworks sometime soon :).

  • _ForgeUser23487 removed a tag Waiting Jul 5, 2011
  • _ForgeUser23487 added a tag Replied Jul 5, 2011

To post a comment, please login or register a new account.