You must login to post a comment. Don't have an account? Register to get one!

• 

  • #11

  Takika Mon, 29 Jun 2009 15:23:20

  Please don't add Ace2 as Required dependency, if you embed parts of Ace2. CurseClient now download the unneeded Ace2 with the current FishingAce.

• 

  • #10

  romracer Fri, 26 Jun 2009 12:36:00

  Yea, I get an error about LibFishing not being able to find an instance of LibCrayon-3.0 with the latest version. Looks like the .pkgmeta or whatever needs to include LibCrayon-3.0 as well.

  Thanks for update!

• 

  • #9

  grum Fri, 26 Jun 2009 07:09:52

  If you use LibFishing-1.0 make sure you also include LibCrayon-3.0 in your package as MINOR_VERSION 2 of LibFishing-1.0 uses it on line 51.

• 

  • #8

  Sutorix Thu, 18 Jun 2009 04:08:50

  I apologize for the long delay between updates the latest version of FishingAce! uses the same code as Fishing Buddy for figuring out the pole, so it should work with everything.

  I'm trying to get it marked as a release version, but even after following the instructions for a release on WoWAce it's still showing up as a beta...

• 

  • #7

  doxxx Sun, 24 May 2009 13:39:43

  The following replacement for the IsFishingPole function makes it work for all known poles as well as any poles added in future patches:

  local function IsFishingPole()
  	local slot = GetInventorySlotInfo("MainHandSlot")
  	local link = GetInventoryItemLink("player", slot)
  	local _, _, _, _, _, _, itemSubType = GetItemInfo(link)
  	return itemSubType == "Fishing Poles"
  end
  

• 

  • #6

  Qrt Wed, 06 May 2009 17:57:02

  Cambri4's modification to r81 seemed to work. However when I switched the 2 weapons on my rogue the addon triggered and thought my char was in 'fishing mode', turning off music etc. Equipping fishing pole and un-equipping didn't help.

• 

  • #5

  Cambri4 Fri, 24 Apr 2009 12:50:42

  I simply love FishingAce!
  But since my recently acquired Jeweled Fishing Pole didn't work with FishingAce r81 either, I started to investigate..
  The new fishing poles don't seem work with FishingAce because it checks the icon name of the equipped mainhand item. Blizzard started using new icons for fishing poles, so it doesn't recognize the new fishing poles introduced in 3.1.
  In order to solve this problem, I took a different approach to the fishing pole recognition.

  First of all, I added a new table including the ItemIDs of every fishing pole in the game.
  You could add this before the FISHINGLURE table

  local FISHINGPOLES = {45992,45991,45858,44050,25978,19970,19022,12225,6367,6366,6365,6256}

  The main changes are in the IsFishingPole() function.
  Just swap this with the old function.

  local function IsFishingPole()
   local slot = GetInventorySlotInfo("MainHandSlot")
   local link = GetInventoryItemLink("player", slot)
   local _, id, _ = SplitLink(link)
   for i,val in ipairs(FISHINGPOLES) do
    if (string.find(id,val)~=(nil)) then
     return true
    end
   end
   return false
  end

  Instead of comparing the Icons, it compares the ItemIDs.
  This way FishingAce can easily be edited for any new fishing poles Blizzard might implement, since you would only have to add the item ID to the FISHINGPOLES table.
  The amount of lines of code is actually the same. There might be a more elegant solution, but it suited my needs.
  I hope this helps all those lucky enough to acquire one of those fancy new fishing poles. :)

  Cambria

• 

  • #4

  Gigi Thu, 23 Apr 2009 22:35:16

  The right click on water to cast seems to be buggy. It won't work with the Jeweled fishing pole. It still works with the Mastercraft Kalu'ak fishing pole. So if I have the Jeweled one on and right click to cast nothing happens. If I switch to the Kalu'ak pole it works. Same thing happens if I go from the Kalu'ak to the Jeweled. No errors pop up or anything. It just doesn't work with the new pole.

  Just figured I would post this since you have updated this mod.

• 

  • #3

  nokia3320 Sat, 29 Nov 2008 00:37:51

  I just search this for a long time , thx

• 

  • #2

  foreverphk Mon, 10 Nov 2008 14:02:31

  I always encounter error on line 313. Here is the fix for all interested: if ( GetCVar("autoLootDefault") == "0" ) then --if ( not GetAutoLootDefault() ) then