WowAce

As of 7.3, cannot click on pop-up faction list to select one to be tracked.

If select new faction from regular faction panel, ElkFactions displays blank in StatBlockCore instead of previously displayed faction.

One Problem is the change in the parameter list of 'PlaySound'

change Line 313ff

elseif isWatched then
   PlaySound(857)
  SetWatchedFactionIndex(0)
else
  PlaySound(856)
  SetWatchedFactionIndex(factionIndex)

end

Petraca,

that does fix the lua error.  However, it's having trouble updating the ldb display with new rep numbers.  Looking in blizzard's UI, you can see what your current faction rep is.  If you select the faction, the ldb does not display the new, gained rep for the session.

I should note that on initial game startup, ElkFactions WILL display whatever your currently selected "show faction as toolbar" is in its LDB display; it just won't update that to a new faction until you quit and restart game.  A /reload is not enough to trigger that change.

You need to change two lines. Line 314 should look like this:

PlaySound(SOUNDKIT.IG_MAINMENU_OPTION_CHECKBOX_OFF)

And line 317 like this:

PlaySound(SOUNDKIT.IG_MAINMENU_OPTION_CHECKBOX_ON)

Line numbering seems different - different editors ignoring comments as lines?

Here's what I did based on previous comments. Changing factions still blanks LDB display until game reload,though.

Original, from line 323                 | Patched, from line 323
....................................... | .........................
elseif isWatched then                   | elseif isWatched then
PlaySound("igMainMenuOptionCheckBoxOff")| PlaySound(857)
SetWatchedFactionIndex(0)               | SetWatchedFactionIndex(0)
else                                    | else
PlaySound("igMainMenuOptionCheckBoxOn") | PlaySound(856)

Hitting exalted, or adding rep beyond exalted, throws another LUA error, although ElkFactions seems to continue on as before otherwise:

Message: Interface\AddOns\ElkFactions\ElkFactions.lua:216: attempt to compare number with nil
Time: 10/05/17 20:08:15
Count: 6
Stack: Interface\AddOns\ElkFactions\ElkFactions.lua:216: attempt to compare number with nil
(tail call): ?
(tail call): ?
Interface\AddOns\ElkFactions\ElkFactions.lua:216: in function `UpdateBaseReputations'
Interface\AddOns\ElkFactions\ElkFactions.lua:190: in function <Interface\AddOns\ElkFactions\ElkFactions.lua:186>
(tail call): ?
[C]: ?
[string "safecall Dispatcher[2]"]:9: in function <[string "safecall Dispatcher[2]"]:5>
(tail call): ?
...ce\AddOns\Archy\Libs\AceBucket-3.0\AceBucket-3.0.lua:116: in function `func'
...face\AddOns\Archy\Libs\AceTimer-3.0\AceTimer-3.0.lua:55: in function <...face\AddOns\Archy\Libs\AceTimer-3.0\AceTimer-3.0.lua:48>

Sorry for the long wait, should be fixed in r33...