17 - [AceHook-3.0] cleanup of the wrapper function created by createHook

Currently, the function createHook does some if checks on values that are constant within the function. Having different functions based on the fixed values for these variables (eg methode, secure) would save a few instructions in the hook chain I think by shifting the checks to the createHook call.

User	When	Change
Nevcairiel	Sat, 04 Apr 2009 15:51:40	Changed status from Accepted to Declined
Nevcairiel	Sun, 15 Feb 2009 13:43:44	Changed component from None to AceHook-3.0
Nevcairiel	Sun, 04 Jan 2009 10:16:05	Changed component from None to AceHook-3.0
Nevcairiel	Sun, 04 Jan 2009 10:15:53	Changed assigned to from Kaelten to Nevcairiel
Nevcairiel	Sun, 04 Jan 2009 10:15:40	Changed status from New to Accepted
Elkano	Thu, 01 Jan 2009 20:33:05	Create

You must login to post a comment. Don't have an account? Register to get one!

2 comments

- #2
Nevcairiel Sun, 04 Jan 2009 12:47:08
Hm ok after looking at it again, its mostly decision between one less if check in the hook chain and creating two more alternative closures, increasing size of the createHook function by factor 2.5.
Probably needs more input, i'm not exactly "pro"
- #1
Nevcairiel Sun, 04 Jan 2009 10:15:50
I'll look at the code again

2 comments

Facts

Last updated on: 04 Apr 2009
Reported on: 01 Jan 2009
Status: Declined - We decided not to take action on this ticket.
Type: Enhancement - A change which is intended to better the project in some way
Priority: Medium - Normal priority.