12 - No lib version stuff
Hello, copystring!
Excuse me, if I'm do some problems for you. :-)
Repository closing not the best idea.
Please, think a little more or kick me.
Your code (rev 213):
## Interface: 30100
## Title: YurrCombatLog
## Notes: CombatLog in SimpleCombatlog style
## Author: copystring
## Version: 0.6
## SavedVariables: YurrCombatLogDB
## OptionalDeps: Ace3, tekDebug
## X-Email: copystring@gmail.com
## X-Category: Combat
Libs\LibStub\LibStub.lua
Libs\CallbackHandler-1.0\CallbackHandler-1.0.xml
Libs\LibDataBroker-1.1.lua
#@no-lib-strip@
## X-Embeds: CallbackHandler-1.0, LibDataBroker-1.1, LibStub
Libs\AceAddon-3.0\AceAddon-3.0.xml
Libs\AceConfig-3.0\AceConfig-3.0.xml
Libs\AceConsole-3.0\AceConsole-3.0.xml
Libs\AceHook-3.0\AceHook-3.0.xml
Libs\AceLocale-3.0\AceLocale-3.0.xml
#@end-no-lib-strip@
localization\YurrCombatLogLocale.lua
localization\zhCN.lua
localization\zhTW.lua
localization\deDE.lua
localization\esES.lua
localization\frFR.lua
localization\koKR.lua
YurrCombatLog.lua
My code (rev 211):
## Interface: 30100
## Title: YurrCombatLog
## Notes: CombatLog in SimpleCombatlog style
## Author: copystring
## Version: 0.6
## SavedVariables: YurrCombatLogDB
## OptionalDeps: Ace3, tekDebug
## X-Email: copystring@gmail.com
## X-Category: Combat
#@no-lib-strip@
Libs\LibStub\LibStub.lua
Libs\CallbackHandler-1.0\CallbackHandler-1.0.xml
#@end-no-lib-strip@
Libs\LibDataBroker-1.1.lua
#@no-lib-strip@
Libs\AceAddon-3.0\AceAddon-3.0.xml
Libs\AceConfig-3.0\AceConfig-3.0.xml
Libs\AceConsole-3.0\AceConsole-3.0.xml
Libs\AceHook-3.0\AceHook-3.0.xml
Libs\AceLocale-3.0\AceLocale-3.0.xml
#@end-no-lib-strip@
localization\YurrCombatLogLocale.lua
localization\zhCN.lua
localization\zhTW.lua
localization\deDE.lua
localization\esES.lua
localization\frFR.lua
localization\koKR.lua
YurrCombatLog.lua
Analysis:
1. "## X-Embeds: CallbackHandler-1.0, LibDataBroker-1.1, LibStub"
CallbackHandler-1.0, LibDataBroker-1.1, LibStub don't have standalone version and according to embedding policy must not be included in #X-Embeds: tag.
2. LibStub.lua and CallbackHandler-1.0 libs must be stripped from no-lib version because it's included in Ace3.
3. Your no-lib version do some include errors ( check FrameXML.log ).
Thanx!
P.S. I'm so sorry for harm you.
| User | When | Change |
|---|---|---|
| copystring | May 14, 2009 at 22:25 UTC | Changed status from New to Fixed |
| Zuz666 | May 14, 2009 at 19:17 UTC | Create |
- 3 comments
- 3 comments
Facts
- Last updated
- May 14, 2009
- Reported
- May 14, 2009
- Status
- Fixed - Developer made requested changes. QA should verify.
- Type
- Other - Some other kind of issue
- Priority
- Medium - Normal priority.
- Votes
- 0
- Reply
- #3
copystring May 14, 2009 at 20:37 UTC - 0 likesHm, weird, i thought CallbachHandler and LibStub are ignored by the repo, i know there were ignored back when the new wowace got launched. I gonna update this accordingly.
- Reply
- #2
Zuz666 May 14, 2009 at 20:22 UTC - 0 likes1. May be but some addon authors have told that are standalone versions not present and current versions must not' be used as standalone versions.
2. Ok. But check docs. For example http://www.wowace.com/projects/libstub/ "don't set LibStub as X-embeded or OptDep".
3. I'm don't use svn versions. YurrCombatLog-r213-nolib toc:
## Interface: 30100
## Title: YurrCombatLog
## Notes: CombatLog in SimpleCombatlog style
## Author: copystring
## Version: 0.6
## SavedVariables: YurrCombatLogDB
## OptionalDeps: Ace3, tekDebug
## X-Email: copystring@gmail.com
## X-Category: Combat
## X-Curse-Packaged-Version: r213
## X-Curse-Project-Name: YurrCombatLog
## X-Curse-Project-ID: yurr-combat-log
## X-Curse-Repository-ID: wow/yurr-combat-log/mainline
Libs\LibStub\LibStub.lua
Libs\CallbackHandler-1.0\CallbackHandler-1.0.xml
Libs\LibDataBroker-1.1.lua
#@no-lib-strip@
# ## X-Embeds: CallbackHandler-1.0, LibDataBroker-1.1, LibStub
#
# Libs\AceAddon-3.0\AceAddon-3.0.xml
# Libs\AceConfig-3.0\AceConfig-3.0.xml
# Libs\AceConsole-3.0\AceConsole-3.0.xml
# Libs\AceHook-3.0\AceHook-3.0.xml
# Libs\AceLocale-3.0\AceLocale-3.0.xml
#@end-no-lib-strip@
localization\YurrCombatLogLocale.lua
localization\zhCN.lua
localization\zhTW.lua
localization\deDE.lua
localization\esES.lua
localization\frFR.lua
localization\koKR.lua
YurrCombatLog.lua
YurrCombatLog-r213-nolib.zip don't contain:
YurrCombatLog\Libs\LibStub\*
YurrCombatLog\Libs\CallbackHandler-1.0\*
and it cause loading errors.
Thanx!
- Reply
- #1
copystring May 14, 2009 at 19:51 UTC - 0 likes