YorsahjAnnounce

5 - Possible lag issues

Reported by bobbank:

There is a problem with the addon.  It causes extreme lag spikes for me during Dragon Soul, but only at certain points.  One point is right after Morchok sucks everyone in with his Earth Vortex.  Another point is Zon'ozz trash, when the eyes shoot their laser.

I think it must have something to do with the code you're using to try to detect whether to load the addon or not?  It doesn't actually cause any lag on Yor'sahj.

Anyway I lost a lot of frame rates due to the mod.  I have tried disabling all my add-on's one by one, so I know this one was causing my issue.  The features are great but this is a big issue for me.

Hope you can find the cause. :)

User When Change
oscarucb Feb 06, 2012 at 09:32 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 3 comments
  • Avatar of oscarucb oscarucb Feb 06, 2012 at 19:59 UTC - 0 likes

    I use Skada and DBM myself and I raid DS 3-4 times a week with YorsahjAnnounce enabled and no problems, so I know those don't have an issue. I stopped using Recount because it performs poorly in DS25, even with everything else disabled. I've never used Raven before and I have no idea what it might be doing, although at a glance i suspect it uses alot more cycles than YA, especially in other fights.

    YorsahjAnnounce only enables itself in the Yorsahj room, which it detects by querying the zone name when you change subzones (there is a game event for that). The addon prints a message to chat when it detects you have entered or left that room. When you are outside that room the addon is completely disabled and there is literally no other code running aside from the occasional event handler. This is why I find it extremely unlikely that it could be affecting performance outside the Yor'sahj room.

    If you want to go a step further, you can comment out the event registration lines in YorsahjAnnounce.lua:545-553 in function addon:OnEnable(). This will disable the event handlers thereby breaking the addon (it will remain permanently disabled), but will ensure that absolutely zero code runs outside the Yorsahj room.

    Another thing worth checking - are you absolutely certain you are using YorsahjAnnounce and not one of the 4-5 other very similarly named addons that do similar things? Some of the alternatives are very poorly written and could easily explain your difficulties.

    Author/Maintainer of BigBrother, ProfessionsVault, InspectFix, RetardCheck, RoleIcons, SavedInstances, and others..

  • Avatar of bobbank bobbank Feb 06, 2012 at 17:06 UTC - 0 likes

    Hello. I actually did a complete delete and reinstall of my interface, cache and wtf folders, as part of my process of trying to diagnose my issues.

    I disabled add-on's, one by one, to be sure I have isolated the problem. For starters I played using only Skada and DBM. I also experienced the issue with BigWigs instead of DBM, and with Recount instead of Skada. The only other add-on I use is Raven. But disabling these other add-on's one by one did not resolve my problem. The only thing that gave my framerates back was turning of YorsahjAnnounce.

    What does the add-on do to determine whether I am fighting Yorsahj or not? There must be some code that is looking at the combat log or something? Maybe it contributes to a bottleneck when the combat log becomes very active?

    I use very few add-ons - right now just Skada, DBM and Raven. If there is a bad interaction with one of these, I think it should be easy for you to reproduce the results on your end. It's possible there is something unique to my system, but I don't think so. Let me know if I can be helpful in tracking it down. Thanks.

  • Avatar of oscarucb oscarucb Feb 06, 2012 at 09:42 UTC - 0 likes

    It's very unlikely that YorsahjAnnounce is the root cause of the problem. This addon doesn't run any code outside of the Yorsahj room - it deregisters all the relevant events otherwise.

    The only possibilities I can think of:

    • If you're running libraries disembedded you may have an old or buggy version of Ace3
    • Both of the cases you mention are very graphic intensive - you may need to adjust your graphical settings (eg turning down particle density, etc)
    • Some other addon may be interfering and triggering a bad behavior

    Please provide your complete list of addons and try again with your graphic settings turned down.

  • 3 comments

Facts

Reported
Feb 06, 2012
Status
Accepted - Problem reproduced / Need acknowledged.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Medium - Normal priority.
Votes
0

Reported by

Possible assignees