X-Perl UnitFrames

109 - Toggle Raid Sort key binding broken

What steps will reproduce the problem?
1. Assign a key to the Toggle Raid Sort
2. Attempt to change the sort using the assigned key while out of combat

What is the expected output? What do you see instead?
For the raid frames to change sort from group to class or vice versa.

What version of the product are you using?
3.0.2a

Do you have an error log of what happened?
No error is thrown.

Please provide any additional information below.
While I don't know if the code is efficient, by replacing the following code block listed below appears to resolve the issue:

in Bindings.xml

<!-- Replace this code block -->
if (XPerl_ToggleRaidSort) then
    XPerl_ToggleRaidSort()
end

<!-- With this code -->
if (not XPerl_Options or not XPerl_Options:IsShown()) then
    if (not InCombatLockdown()) then
        if (New) then
            XPerlDB.raid.sortByClass = New == 1
        else
            if (XPerlDB.raid.sortByClass then
                XPerlDB.raid.sortByClass = nil
            else
                 XPerlDB.raid.sortByClass = 1
            end
        end
            XPerl_Raid_ChangeAttributes()
        XPerl_Raid_Position()
        XPerl_Raid_Set_Bits(XPerl_Raid_Frame)
    end
end

User When Change
Zeksie Aug 08, 2009 at 00:49 UTC Changed status from New to Declined
AcidBee Mar 07, 2009 at 10:53 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 1 comment
  • Avatar of Zeksie Zeksie Aug 08, 2009 at 00:49 UTC - 0 likes

    I fail to see how this helps anything, the code block you gave is exactly the contents of the XPerl_ToggleRaidSort() function.

  • 1 comment

Facts

Last updated
Aug 08, 2009
Reported
Mar 07, 2009
Status
Declined - We decided not to take action on this ticket.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Medium - Normal priority.
Votes
0

Reported by

Possible assignees