WhoLib

22 - wow 5.3 - all queries return as complete true

What steps will reproduce the problem?
1.use libwho:Who with arg of 90-90 on high pop server  when return has count of 50
2.use libwho;who with arg of 90-90 c-"eachclass" and get counts that total more then 50
3.Use CensusPlus version Toc 50200 release with out of date enabled.. and compare with version for 50300 which disables libwho usage.

What is the expected output? What do you see instead?
libwho calls api numResults, totalCount = GetNumWhoResults()
pre 5.3 this would return at max  49, 50  which would trigger complete flag as false
with 5.3 this now returns at max 50, 50  and complete is set as true   always
I have not yet found anything from Blizzard as to why/how they changed this return result for GenNumWhoResults().

What version of the product are you using?
CensusPlus addon has been using whoLib 2.0.117 since the only change with that and .122 is the change to the minor version number
otherwise the LibWho-2.0.lua is identical.

Do you have an error log of what happened?

Please provide any additional information below.
Currently CensusPlus has reverted to using the default api which means it can conflict with Wim and other libwho users. If we can get an update that again enables valid complete flag returns, I'll reset CensusPlus back to using LibWho.

User When Change
sylvanaar May 30, 2013 at 22:09 UTC
sylvanaar May 30, 2013 at 22:04 UTC
bringoutyourdead May 22, 2013 at 23:14 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 2 comments
  • Avatar of sylvanaar sylvanaar May 30, 2013 at 22:09 UTC - 0 likes

    Revision: 123 Author: sylvanaar Date: Thursday, May 30, 2013 6:08:47 PM Message: Suggested change by esiemiat. Need to test.


    Modified : /trunk/LibWho-2.0/LibWho-2.0.lua

  • Avatar of esiemiat esiemiat May 23, 2013 at 15:27 UTC - 0 likes

    Change line 507 in "LibWho-2.0.lua"

    From:

    local complete = self.Total == #self.Result
    

    To:

    local complete = (self.Total == #self.Result) and (self.Total < MAX_WHOS_FROM_SERVER)
    

    I tested this out with CensusPlus and it looked like it worked. Hope this helps.

  • 2 comments

Facts

Last updated
May 30, 2013
Reported
May 22, 2013
Status
Started - Work on this issue has begun.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Medium - Normal priority.
Votes
1

Reported by

Possible assignees