WeakAuras

92 - Weapon-Enchant Rebuff - no update

I have a nice progress bar for my temporary weapon-enchants:

deJsbaGlPWRLKmBO0nLe9nfzNQYEr7gY(vu)usPHrj)MQgScnCICmcDoPQwiuzXuXYP4HskEk4XqvpxOBRKMkbtwvnDsxusvNwWLfDDj2OKWHvzZuPTdfBtb9vPkFMs9DPsJuQyAsPgTuY4Luzze1TKK6AsrNxPACkWZuk)vjMIuGWkHpHpfiys7GhjSlLeUI5CodH9ADDJPY3uJMeI6HVQiDiC)FqdE0HDrnbB70ePavcAwNwmjHo5H1XRecFcv2zESNeAEexX1LGAc22PHce0DPKqupTejKysKsOxEsE08y9i8ToKsaFjQ(1LwHFsqdR5Nq38K8icRxarOeZLU5j5rehHckXKiLWvupHsmxkOGsCuj4CMA8y9gkWNiFw8jZkA3uwuEO1al5TP(t9LPB1dT4BJprQujeji2yZP98OzAabm8jUzjtLe

If I refresh the enchants while they are still active, the timer won't update (until opening the /wa-config).
This bug is new since 1.3b5, previous version didn't have this bug.

(I guess, you're starting to get annoyed by me for finding all these bugs, sry :P)

User When Change
Mirrormn Jan 30, 2011 at 23:43 UTC Changed status from Accepted to Fixed
Mirrormn Jan 30, 2011 at 21:24 UTC Changed status from New to Accepted
Ravengus Jan 30, 2011 at 13:09 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 5 comments
  • Avatar of Ravengus Ravengus Feb 01, 2011 at 19:21 UTC - 0 likes

    works perfect, thanks!

  • Avatar of Mirrormn Mirrormn Jan 30, 2011 at 23:42 UTC - 0 likes

    My suspicions are confirmed; adding a timer that delays the check for 0.1s causes it to behave properly. I don't really like using a timer for this purpose, but as far as I can tell, there is actually no event that fires at the proper time for Weapon Enchant info updates.

    Fixed in r80.

  • Avatar of Mirrormn Mirrormn Jan 30, 2011 at 23:21 UTC - 0 likes

    It does fire when Shamans enchant their weapons; if it didn't, the display wouldn't show at all. However, I suspect it fires slightly too soon.

  • Avatar of Ravengus Ravengus Jan 30, 2011 at 23:18 UTC - 0 likes

    Shaman weapon enchants are spells - so I think there will be no UNIT_INVENTORY_CHANGED, am I right?

  • Avatar of Mirrormn Mirrormn Jan 30, 2011 at 21:23 UTC - 0 likes

    In 1.3b5 I changed the triggering event for Weapon Enchant triggers from UNIT_AURA to UNIT_INVENTORY_CHANGED, which made Weapon Enchant triggers update much more quickly. I think I now remember that the reason I had it on UNIT_AURA in the first place is because weapon enchant info is not all properly available at the UNIT_INVENTORY_CHANGED event. *Sigh*.

    Quote from Ravengus:

    (I guess, you're starting to get annoyed by me for finding all these bugs, sry :P)

    On the contrary; I would much rather have a bug reported than not.

    Last edited Jan 30, 2011 by Mirrormn
  • 5 comments

Facts

Last updated
Jan 30, 2011
Reported
Jan 30, 2011
Status
Fixed - Developer made requested changes. QA should verify.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Medium - Normal priority.
Votes
0

Reported by

Possible assignees