WeakAuras 2

27 - "Item equipped" does not work

"Status"/"Item equipped" does not work: If item is changed for a second time: Trigger does not fire. WeakAuras2 version from 10/2013. Problem already described in :

http://www.wowace.com/addons/weakauras/tickets/258-status-item-equipped-trigger-not-untriggering
http://www.wowace.com/addons/weakauras/tickets/414-status-item-equipped-does-not-work-correctly

User When Change
Stanzilla Dec 07, 2014 at 23:44 UTC Changed status from New to Fixed
InfusOnWow Nov 26, 2014 at 07:57 UTC Changed type from Defect to Patch
rudinachtelf Nov 26, 2013 at 18:36 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 9 comments
  • Avatar of Stanzilla Stanzilla Dec 07, 2014 at 23:43 UTC - 0 likes

    Done, thanks!

  • Avatar of InfusOnWow InfusOnWow Dec 06, 2014 at 16:41 UTC - 0 likes

    So after some more testing and reading of the code, I agree with brawne42, that his patch is the way to go. Sorry for taking so long to come back to this.

    @Stanzilla, can you apply it?

  • Avatar of brawne42 brawne42 Nov 26, 2014 at 23:59 UTC - 0 likes

    Both "automatic = true" and "automaticRequired = true" occur in different prototypes.

    Unfortunately I'm not familiar enough with to determine the difference (I would be interested to know what the functional difference is)

    For Item Equipped, "automaticRequired" had been commented out during an overhaul of its implementation awhile ago, so that's why I picked that one over "automatic".

  • Avatar of InfusOnWow InfusOnWow Nov 26, 2014 at 08:33 UTC - 0 likes

    Ah, I forgot, Thanks for your patch. That's greatly appreciated.

  • Avatar of InfusOnWow InfusOnWow Nov 26, 2014 at 08:32 UTC - 0 likes

    As far as I can tell the patch works, but I think it's slightly wrong. From what I can see reading the code, it should be "automatic = true" not "automaticRequired = true"

    But then again, I have just seen that code for the first time.

  • Avatar of brawne42 brawne42 Nov 26, 2014 at 03:55 UTC - 1 like

    This is seems to be caused by WeakAuras.EndEvent not being called for "Item Equipped" event prototypes.

    The bug can be resolved by setting automaticrequired = true on the "Item Equipped" prototype.

    From 80fb4dbeecfa89ef2a9689c95fa1814d19ee0610 Mon Sep 17 00:00:00 2001
    From: brawne <brawne@eclipse.id.au>
    Date: Wed, 26 Nov 2014 14:36:55 +1100
    Subject: [PATCH] make sure ItemEquip auras untrigger when item is unequipped
    
    ---
     Prototypes.lua | 2 +-
     1 file changed, 1 insertion(+), 1 deletion(-)
    
    diff --git a/Prototypes.lua b/Prototypes.lua
    index 6f2b24f..3178d6e 100644
    --- a/Prototypes.lua
    +++ b/Prototypes.lua
    @@ -2440,7 +2440,7 @@ WeakAuras.event_prototypes = {
           end
         end,
         hasItemID = true,
    -    --automaticrequired = true
    +    automaticrequired = true
       },
       ["Threat Situation"] = {
         type = "status",
    --
    
  • Avatar of squiddoKJ squiddoKJ Nov 03, 2014 at 22:06 UTC - 0 likes

    I want to use this to remind me which weapon my fury warrior is using so I can switch between weapons in combat. Please fix this.

  • Avatar of bessiq bessiq Jul 27, 2014 at 02:16 UTC - 0 likes

    Same for me. Using Inverse of Item Equipped so I don't forget trinket in battlegrounds, but it triggers even with trinket equipped. Opening and closing the WeakAuras config makes it go away until next time.

    Oh, using 2.0.7!

    Last edited Jul 27, 2014 by bessiq
  • Avatar of Lander23 Lander23 Mar 14, 2014 at 16:43 UTC - 0 likes

    I have the same issue, opening and closing the weak auras menu fixes it temporarily.

  • 9 comments

Facts

Last updated
Dec 07, 2014
Reported
Nov 26, 2013
Status
Fixed - Developer made requested changes. QA should verify.
Type
Patch - Source code patch for review
Priority
Medium - Normal priority.
Votes
6

Reported by

Possible assignees