TradeskillInfo

23 - Modification to string placement

What is the enhancement in mind? How should it look and feel?

Slight movement of the skill level string in the trade skill window to accommodate the cool down string

I happen to use ATSW and noticed the skill string 415/425/430/435 for example was attached to the end of the Requires: Maw of Neltharion string

eg;
        Requires: Maw of Neltharion, 415/425/430
                       /435

this is what normally shows when the skill level option is active

when there is a cooldown, it writes it over top of /435

I changed the code thus to move that string down 2 lines

in tradeskillinfo.lua

line 543

                       if ATSWRequirementLabel:IsVisible() then
                text = ATSWRequirementText:GetText() .. "\n\n Skill Level: ";
            end

now it looks like

      Requires: Maw of Neltharion
      Cooldown remaining 3 Days 19 Hr
                     Skill Level: 415/425/430/435

Please provide any additional information below.

  • WoWScrnShot_100209_124131.png
User When Change
Dys Fri, 06 Nov 2009 23:12:41 Changed status from New to Fixed
WMerkens Fri, 02 Oct 2009 18:44:39

Added attachment WoWScrnShot_100209_124131.png

WMerkens Fri, 02 Oct 2009 18:44:17 Create

You must login to post a comment. Don't have an account? Register to get one!

  • 2 comments
  • Avatar of Dys Dys Fri, 06 Nov 2009 23:12:30

    Skillet layout needed no modification. I've changed the layout for Blizzard frames in a similar fashion.

    Closing the ticket.

  • Avatar of Dys Dys Sun, 04 Oct 2009 07:50:36

    I have made the necessary modification in r345. I will need to check the standard and Skillet windows for the same problem, and make changes, if necessary before I do a release with this change.

    Thanks for the fix.

  • 2 comments

Facts

Last updated on
06 Nov 2009
Reported on
02 Oct 2009
Status
Fixed - Developer made requested changes. QA should verify.
Type
Enhancement - A change which is intended to better the project in some way
Priority
Medium - Normal priority.

Reported by

Possible assignees