Tank Warnings

11 - Fix isInRaid, Add proper fallback to party chat, add Monk

I firstly fixed isInRaid() which should have been IsInRaid(), also you can not do > 0 on a boolean, so removed that.

Secondly I made it so it checks if you are able to use RaidWarnings if not use Raid if not in Raid use Party, much more useful this way, might want to add some config for it though.

Thirdly I added Monks, I'm not pro monk so this is very very preliminary but thought I'd try and start it for you as I love this addon and wanted to add back to it.

Thanks for this add on and I hope this helps you and others.

Name Description Size MD5
TankWarnings.fixed_monk.patch Patch against 1.32 13.9 KiB 3cf74782789e...
User When Change
rbarreiros Dec 04, 2012 at 23:14 UTC
TheSin Dec 04, 2012 at 21:40 UTC

Added attachment TankWarnings.fixed_monk.patch

TheSin Dec 04, 2012 at 21:40 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • Avatar of TheSin TheSin Dec 28, 2012 at 16:06 UTC - 0 likes

    yup no problem at all just wanted a place to remind ya. Take a look at my other patch too it adds a few more controls for this fallback.

  • Avatar of rbarreiros rbarreiros Dec 26, 2012 at 02:57 UTC - 0 likes

    Got back home monday from a big gig and got Christmas in the middle, will update the page tomorrow/after tomorrow.

  • Avatar of TheSin TheSin Dec 07, 2012 at 23:52 UTC - 0 likes

    Oh and don't forgot to update the front page here and on curses since it now supports brewmaster monks too. :P

  • Avatar of TheSin TheSin Dec 07, 2012 at 16:20 UTC - 0 likes

    just to confirm SVN works perfectly, I just added a new ticket for the fallback options, also rewrote the if blocks to be a little cleaner.

    Thanks again for this wonderful plugin.

  • Avatar of TheSin TheSin Dec 07, 2012 at 15:06 UTC - 0 likes

    @rbarreiros: Go

    no problem at all and if I find more chances as my tanks hit 90 I'll be sure to let you know, and hopefully today I will work on make the announce channel thing into an option.

    I'll try and grab snv today so that i can test it and make all future patches against it and I'll open new tickets for them and let this one rest now ;)

  • Avatar of rbarreiros rbarreiros Dec 07, 2012 at 11:08 UTC - 0 likes

    Ok, svn tree has all the changes, and tagged it 1.4, new minor version for the new expansion. Right now, I don't have WoW easily available to thoroughly test this changes, so I'll wait a bit and see if anyone complaints about anything before tagging it a release.

    Keep up the nice work, and thanks for the hard work you did.

  • Avatar of TheSin TheSin Dec 06, 2012 at 18:45 UTC - 0 likes

    excellent :D so excited to help out :D

  • Avatar of rbarreiros rbarreiros Dec 06, 2012 at 18:41 UTC - 0 likes

    No worries, I'll sort the patch stuff.

  • Avatar of TheSin TheSin Dec 06, 2012 at 18:36 UTC - 0 likes

    Damn this new patch is a full patch against 1.32 and I updated the toc to 5.1 as well in it ;)

    I haven't had time to make the fallback to raid and party an option yet going to work on that tonight for you.

    Here is the full patch this has everything from before, monk, druid, isInRaid fix and the fallbacks plus warrior and pally updates.

    Name Description Size MD5
    TankWarnings.5.1.patch Patch Against 1.32 49.1 KiB ebf7328573e3...
  • Avatar of rbarreiros rbarreiros Dec 06, 2012 at 18:26 UTC - 0 likes

    Just applied your patches and updated TOC, tagged a beta version and I'll wait for you changes when the monk/dk hit lvl 90. In the meanwhile, any error yell at me.

    Best regards.

Facts

Last updated
Dec 04, 2012
Reported
Dec 04, 2012
Status
Accepted - Problem reproduced / Need acknowledged.
Type
Enhancement - A change which is intended to better the project in some way
Priority
Medium - Normal priority.
Votes
0

Reported by

Possible assignees