Talented

58 - Assertion failed during apply talent on PTR

What steps will reproduce the problem?
1. use a predefined talent built
2. press apply talent
3.

What is the expected output? What do you see instead?
an error message

What version of Talented are you using? what version of the Wow client are you using?
Installed:v2.3-release (Released: 2009/06/06)
PTR 3.2

Do you have an error log of what happened?
[2009/06/28 12:52:53-1907-x1]: Talented-2.3\apply.lua:48 assertion failed!
Talented-2.3\apply.lua:48 in function `ApplyTalentPoints'
Talented-2.3\apply.lua:43 in function `ApplyCurrentTemplate'
Talented-2.3\core.lua:73 in function `SetMode'
Talented-2.3\ui\menu.lua:331 in function `func'
Interface\FrameXML\UIDropDownMenu.lua:563 in function `UIDropDownMenuButton_OnClick':
<string>:"*:OnClick":1: in function <[string "*:OnClick"]:1>

  ---

Please provide any additional information below.
I think it's a failsafe check to prevent old talents to be applied to newer ones. Would it be possible to supply an alpha for the PTR?

Make sure to include your character's class and locale if your issue is related to Talented disabling itself.

User When Change
jerry Mon, 03 Aug 2009 09:08:59 Changed status from Accepted to Fixed
jerry Thu, 02 Jul 2009 13:10:48 Changed status from Replied to Accepted
essmene Thu, 02 Jul 2009 12:03:09 Changed status from Waiting to Replied
jerry Mon, 29 Jun 2009 08:59:58 Changed status from New to Waiting
essmene Sun, 28 Jun 2009 11:18:50 Create

You must login to post a comment. Don't have an account? Register to get one!

  • 4 comments
  • Avatar of jerry jerry Mon, 03 Aug 2009 09:08:51

    This bug cannot occur anymore with Talented 2.4

  • Avatar of jerry jerry Thu, 02 Jul 2009 13:10:08

    You can remove Talented_Data.

    I am going to change the code here. The change will be committed with the rest of the 3.2 compatible changes when 3.2 is deployed on live.

    Instead of an assertion, the new code will silently change the value of this cvar long enough to use the API, and then will revert it to it's previous value. This should fix your issue.

  • Avatar of essmene essmene Thu, 02 Jul 2009 12:03:09

    Hi Jerry,

    currently i am not aware of any other addon messing with talents. I will try talented alone and see if it works.

    I had enabled:

    • Bugsack
    • Buggrabber
    • talented Installed:v2.3-release (Released: 2009/06/06)
    • Talented_data Installed:r206 (Released: 2009/04/23) (which for some reason had "release" tagged instead of "alpha"). Installed the alpha instead. Upon login i get: ------ [2009/07/02 14:16:38-1915-x1]: Talented-2.3\core.lua:281: attempt to index global 'InterfaceOptionsDisplayPanelPreviewTalentChanges' (a nil value) (tail call): ?: <in C code>: ? <string>:"safecall Dispatcher[1]":9: in function <[string "safecall Dispatcher[1]"]:5> (tail call): ?: AceAddon-3.0-5 (BugSack):531: in function `EnableAddon' AceAddon-3.0-5 (BugSack):621: in function <...ce\AddOns\BugSack\Libs\AceAddon-3.0\AceAddon-3.0.lua:607> <in C code>: in function `LoadAddOn' Interface\FrameXML\UIParent.lua:229: in function `UIParentLoadAddOn': Interface\FrameXML\UIParent.lua:252: in function `CombatLog_LoadUI': Interface\FrameXML\UIParent.lua:499: in function <Interface\FrameXML\UIParent.lua:471>:

    -

  • Avatar of jerry jerry Mon, 29 Jun 2009 08:59:45

    The assertion on line 48 is :

        assert (GetCVarBool"previewTalents")
    

    When enabled, Talented sets previewTalents to true.

    So the issue is that another addon has reverted previewTalents between the moment Talented was enabled and you tried to apply a spec.

    This is not a bug in Talented, strictly speaking.

    I don't know if the preview API works correctly if the cvar is not set to "1". That's why I added this assertion before using the API to apply the spec.

    When using Talented, you shouldn't have to change the value of this cvar, as it's use is irrelevent to you while you're using Talented.

    Do you have any idea why this cvar was modified after Talented was enabled ?

  • 4 comments

Facts

Last updated on
03 Aug 2009
Reported on
28 Jun 2009
Status
Fixed - Developer made requested changes. QA should verify.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Medium - Normal priority.

Reported by

Possible assignees